castleproject / Core

Castle Core, including Castle DynamicProxy, Logging Services and DictionaryAdapter
http://www.castleproject.org/
Other
2.2k stars 467 forks source link

Update `FrameworkDisplayName` in `ref/` contract files #641

Closed stakx closed 1 year ago

stakx commented 1 year ago

It appears that the .NET compilers previously left this custom attribute property empty, but have now started setting it.

stakx commented 1 year ago

What is this new devilry?

Took me a moment to figure out what went wrong here: apparently, .NET tooling started to provide a value for FrameworkDisplayName, except the .NET 6 SDK, which left it empty. This has apparently been fixed in https://github.com/dotnet/sdk/pull/24656, and if we use the .NET 7 SDK when targeting .NET 6, the problem goes away.