search

castleproject / Core

Castle Core, including Castle DynamicProxy, Logging Services and DictionaryAdapter
http://www.castleproject.org/
Other
2.2k stars 467 forks source link

Release 5.1.1 #644

Closed stakx closed 1 year ago

stakx commented 1 year ago

We have three bugfixes ready that I'd like to get published as soon as possible. (More precisely, before January 3rd, which is when I'll get busy once again with my daytime job. 😁) Since it's only bugfixes at this point, this would be a patch-version release (5.1.1).

There's currently three open issues / PR that would be good candidates to be included in the next release, too; however they all need a little more time, so I suggest we don't wait for them:

jonorossi commented 1 year ago

Sounds great, you did 5.1.0 without a problem, so go ahead when you're ready.

I can see what you mean about probably not needing to mention contributors by username in the changelog anymore since GitHub has a "Contributors" section on releases now. 😕 Actually does that section only show usernames that are mentioned, see 5.0.0-beta001 is empty?

FYI, I renamed you issue to match the previous ones which is meant to be read as release the verb rather than noun.

stakx commented 1 year ago

FYI, I renamed you issue [...]

Got it! I remembered that incorrectly and didn't doublecheck. Thanks for the hint & explanation.

I can see what you mean about probably not needing to mention contributors by username in the changelog anymore [...]

Oh, I didn't intend to suggest we drop usernames completely (even though that's obviously an option, too). Nice to see GitHub now determines code contributors automatically (from the commit history starting just after the previous release, I guess), that means we could indeed favor mentioning issue reporters instead of code contributors in the changelog... that way, both parties end up getting credited in some way.

jonorossi commented 1 year ago

Oh, I didn't intend to suggest we drop usernames completely (even though that's obviously an option, too). Nice to see GitHub now determines code contributors automatically (from the commit history starting just after the previous release, I guess), that means we could indeed favor mentioning issue reporters instead of code contributors in the changelog... that way, both parties end up getting credited in some way.

I guess you didn't see my edit 😃, not sure that is how it works, so we'll need to continue doing what we're doing.

stakx commented 1 year ago