castleproject / Core

Castle Core, including Castle DynamicProxy, Logging Services and DictionaryAdapter
http://www.castleproject.org/
Other
2.2k stars 467 forks source link

Log4Net not listed in dependencies #650

Closed brettshearer closed 1 year ago

brettshearer commented 1 year ago

In 5.0.0 release notes:

Upgrade log4net to v2.0.13 (@jonorossi, @stakx, @dschwartzni, https://github.com/castleproject/Core/pull/574, https://github.com/castleproject/Core/pull/605)

Yet log4net doesn't appear in dependencies on this page: https://www.nuget.org/packages/Castle.Core

Here is the reference: https://github.com/castleproject/Core/blob/master/src/Castle.Services.Logging.SerilogIntegration/Castle.Services.Logging.SerilogIntegration.csproj

stakx commented 1 year ago

Seems like you're looking at the wrong project and at the wrong package.

The Castle.Core–log4net integration project is here:
https://github.com/castleproject/Core/blob/master/src/Castle.Services.Logging.log4netIntegration/Castle.Services.Logging.log4netIntegration.csproj

And the NuGet package is here:
https://www.nuget.org/packages/Castle.Core-log4net

And voilà, the dependency is right where it should be.

jonorossi commented 1 year ago

@brettshearer The second link you provided is the project file for Castle.Core-Serilog, not really sure why you provided that, the log4net project and package is:

stakx commented 1 year ago

Wow, almost identical answers with identical links at almost exactly the same time, @jonorossi. We must be quantum entangled or something.

brettshearer commented 1 year ago

excellent - thanks. I'm in a massive entanglement session and got this wrong.