search

castleproject / NVelocity

Castle's NVelocity
Other
57 stars 33 forks source link

Make build work in AppVeyor #2

Closed phillip-haydon closed 6 years ago

phillip-haydon commented 6 years ago

This currently builds successfully in AppVeyor.

https://ci.appveyor.com/project/phillip-haydon/nvelocity/build/1.0.7

jonorossi commented 6 years ago

@phillip-haydon FYI your commits are showing unassociated from a groupimd.com email, was that intentional?

phillip-haydon commented 6 years ago

I committed from work, just forgot to update my config on the project, will fix it now, thanks for pointing that out.

phillip-haydon commented 6 years ago

Ok I've updated this PR.

Next would be to upgrade to .NET Standard for NVelocity, and .NET Core for NVelocity.Tests. (Does dotnet test run nunit or do we need to upgrade to xunit?)

jonorossi commented 6 years ago

Ok I've updated this PR.

Great, I'll check it out after dinner.

Does dotnet test run nunit or do we need to upgrade to xunit?

Yes, check out the build scripts we've built for Castle Core and Windsor, they do automatic version numbering from Git tags and other stuff. If you like you can do this one exactly the same.

phillip-haydon commented 6 years ago

Yup I'll check them out and include everything I can.

phillip-haydon commented 6 years ago

By the way what time zone are you in? I’m in Singapore so it’s 5:40pm here. You must be close?

jonorossi commented 6 years ago

I’m in Singapore so it’s 5:40pm here

I'm in Brisbane, Australia; so 2 hours ahead.

jonorossi commented 6 years ago

Great, let me know when you are ready to merge.

phillip-haydon commented 6 years ago

Happy for you to merge. I’m heading home so I’ll begin working on the next lot of updates tomorrow.

jonorossi commented 6 years ago

(A small aside for consideration at a later time: There are some files with extensions .vm, .vm.disabled, and .properties in the test project. I was wondering whether there should be dedicated entries for them in .editorconfig at some point.)

Maybe .properties, but .vm probably best not. I would expect some tests have spaces and some tabs to actually test the template renders properly with whitespace. NVelocity can be really annoying with whitespace which forces you to use curly braces more often.

jonorossi commented 6 years ago

Thanks @phillip-haydon, great work. Merged.