search

castleproject / NVelocity

Castle's NVelocity
Other
57 stars 33 forks source link

Release 1.2.0 #9

Closed phillip-haydon closed 5 years ago

phillip-haydon commented 6 years ago

Initial release of rebooted NVelocity. The primary driving force of this release is to bring support for .NET Standard 2.0 for people who still use NVelocity, and those who wish to use it in new projects.

@castleproject/committers your input?

jonorossi commented 6 years ago

@phillip-haydon Sorry for the delay replying. We need to:

emagers commented 5 years ago

Any update on the release date?

phillip-haydon commented 5 years ago

Sorry! My baby was born and so I’ve been busy, currently in Taiwan with the rest of the family and don’t own a laptop at the moment :(

I’ll try get this finished when I’m back next month. Unless someone else wants to get this over the line.

jonorossi commented 5 years ago

Thanks Eric for getting the AppVeyor script fixed.

For some reason the unit tests now fail in the Linux build, we need to fix that before releasing.

jonorossi commented 5 years ago

@phillip-haydon congrats on the baby 🎉, I hope everyone is well.

phillip-haydon commented 5 years ago

05ce5c42-4441-4de0-91ce-29d5a727d25a

Azabeth says hello.

I can take a look at the unit tests on Monday onward. I’m back in singapore just need to catch up on things first.

emagers commented 5 years ago

Congratulations, Phillip!

Is there anyway for me to see the test errors, or get any information on the test environment (like OS version, what dotnet SDK is installed)? I just ran the build and tests locally on Ubuntu 16.04 with the latest dotnetcore 2.2 SDK and it was successful.

jonorossi commented 5 years ago

@emagers yep, you can navigate to the build details for master from the branches page: https://github.com/castleproject/NVelocity/branches

jonorossi commented 5 years ago

The problem looks culture related:

ht = new Hashtable(StringComparer.CurrentCultureIgnoreCase);

Not sure if AppVeyor has changed the culture the machines are configured with. Changing our test to StringComparer.OrdinalIgnoreCase will probably fix the problem.

emagers commented 5 years ago

@jonorossi Is there a way to test on AppVeyor without merging into master? I can make that change but would like to test before opening a PR, and since it's already not failing locally I can't test this solves anything.

jonorossi commented 5 years ago

Is there a way to test on AppVeyor without merging into master? I can make that change but would like to test before opening a PR

All pull requests are built, you'll see the build status shown at the bottom. Or you could create your own AppVeyor account against your fork. I'd just create a pull request.

emagers commented 5 years ago

Haha okay, I guess I missed it when I opened my last PR. The build status isn't normally so hidden

emagers commented 5 years ago

I opened a new PR which fixes the failing test cases

jonorossi commented 5 years ago

I've also logged #13 and #14 for someone to look at, no rush.

Thanks guys, sorry for being so slow getting this released.