search

castleproject / Windsor

Castle Windsor is a best of breed, mature Inversion of Control container available for .NET
http://www.castleproject.org
Apache License 2.0
1.52k stars 456 forks source link

Make Castle.Windsor.Extensions.DependencyInjection depend on abstractions #624

Closed ikkentim closed 2 years ago

ikkentim commented 2 years ago

Castle.Windsor.Extensions.DependencyInjection currently depends on the implementations of the hosting and logging extensions. It would be nice if it could depend on the abstractions instead.

- <PackageReference Include="Microsoft.Extensions.Hosting" Version="3.1.3" />
- <PackageReference Include="Microsoft.Extensions.Logging" Version="3.1.3" />
+ <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="3.1.3" />
+ <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="3.1.3" />
jonorossi commented 2 years ago

I asked the same question when this was contributed by a previous contributor and was told it had to work that way. Gladly accept the change.

ikkentim commented 2 years ago

I've attached a pull request for this change.