search

castor-data-binding / castor

http://castor-data-binding.github.io/castor/
35 stars 29 forks source link

Collections of type Set or SortedSet generate code that does not compile #48

Closed aner-perez closed 8 years ago

aner-perez commented 8 years ago

resolves #47 useJava50 boolean parameter was added to createGetByIndexMethod(...) in CollectionMemberAndAccessorFactory but it was not added to overridden method in CollectionJ2NoIndexMemberAndAccessorFactory

aner-perez commented 8 years ago

parent/pom.xml has a dependency on castor-maven-plugin version 3.0-SNAPSHOT which causes the build to fail. I had to change this version to 2.1 to get my local build to work but I did not commit that change.

aner-perez commented 8 years ago

In this case having these methods annotated with @Override would have made these types of issues a lot more obvious but I guess it would take some considerable effort to go back and add these annotations. Might be worthwhile to add this as an enhancement or to some TODO list somewhere.

wguttmn commented 8 years ago

Yes, that Maven plugin is work in progress right now. Privately rolling this back is the correct solution in your case, indeed.

wguttmn commented 8 years ago

Merged pull request, and added missing @Override annotations to this class hierarchy.