castorini / castor

PyTorch deep learning models for text processing

http://castor.ai/

Apache License 2.0

178 stars 58 forks source link

conv_rnn refactoring #102

Open lintool opened 6 years ago

lintool commented 6 years ago

Ref #99

conv_rnn and kim_cnn are both sentence classification models - they should share the same API, and in general be structured the same way.

@Impavidity @daemon please coordinate on this.

daemon commented 6 years ago

99 #101

Maybe we can have all the shared modules in /common/ and the model-specific stuff in the current directories. For example, the user runs something like python -m conv_rnn from the base directory.

tuzhucheng commented 6 years ago

SST-1 torchtext Dataset is now available in the datasets module. SST-2 will be added in the next 2 weeks.