search

castorini / castor

PyTorch deep learning models for text processing
http://castor.ai/
Apache License 2.0
178 stars 58 forks source link

Upgrade torchtext to 0.3 #139

Closed Victor0118 closed 6 years ago

Victor0118 commented 6 years ago

Combined with minor bug fixes.

@tuzhucheng Could you review this?

tuzhucheng commented 6 years ago

But v0.3 is not released yet.. https://github.com/pytorch/text/releases

We should stick with stable releases instead of master branch unless we need a particular feature from it.

Victor0118 commented 6 years ago

I see. That makes sense to me!

tuzhucheng commented 6 years ago

However, this branch is useful to keep once v0.3 does become available!

Victor0118 commented 6 years ago

Yes. I will keep it. Close this PR now.