search

castorini / castor

PyTorch deep learning models for text processing
http://castor.ai/
Apache License 2.0
178 stars 58 forks source link

Add charquantize for AAPD #173

Closed Ashutosh-Adhikari closed 5 years ago

Ashutosh-Adhikari commented 5 years ago

Need to add charquantize to AAPD as it was breaking the code. CC: @achyudhk , @daemon

achyudh commented 5 years ago

LGTM but to reduce code duplication I think it might be possible to import char_quantize from one of the other modules (say Reuters?)

Ashutosh-Adhikari commented 5 years ago

I think this is better as if someone wants to provide different args for AAPD, they can do it independently. And anyway, all other dataset files already have it. @daemon , can you please review this.