search

castorini / hedwig

PyTorch deep learning models for document classification
Apache License 2.0
595 stars 126 forks source link

Correct save location for trained model #47

Open parismic opened 4 years ago

parismic commented 4 years ago

It seems that the save path is incorrectly documented.

In the args the default dir is model_checkpoints and the README.md says models/bert/saves/Reuters/best_model.pt. I test it on SST-2 and the trained model was saved at model_checkpoints.

Or are these two different things?

See: https://github.com/castorini/hedwig/blob/c602b82f31b22db206c1879b9725227c04ba5eca/models/bert/args.py#L11

Ashutosh-Adhikari commented 4 years ago

@parismic , yes that's an issue to be resolved. Thanks for pointing it out.