search

castorini / pygaggle

a gaggle of deep neural architectures for text ranking and question answering, designed for Pyserini
http://pygaggle.ai/
Apache License 2.0
329 stars 97 forks source link

Additional task to Initial Screening #295

Open 1Basile opened 1 year ago

ronakice commented 1 year ago

Hey @1Basile thanks for the PR. By the way can you delete all the unnecessary files/file channges? As you can see your commit has changed over a hundred files.

1Basile commented 1 year ago

Already done. Sorry for that, haven't seen.

ronakice commented 1 year ago

Hey @1Basile it still seems like many useless files persist?

1Basile commented 1 year ago

Hi, I forgot about this. My bad. I'll fix everything till Monday. It works?

чт, 29 вер. 2022, 10:18 PM користувач Ronak @.***> пише:

Hey @1Basile https://github.com/1Basile it still seems like many useless files persist?

— Reply to this email directly, view it on GitHub https://github.com/castorini/pygaggle/pull/295#issuecomment-1263025460, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANLT4ECXEYSHWUNXPSWACMDWAZEXTANCNFSM55Q7YLBA . You are receiving this because you were mentioned.Message ID: @.***>

1Basile commented 1 year ago

I can not delete files, as they show the workflow. I reduced the size of those files to 100k each, so it should not be that bad.

ronakice commented 1 year ago

All these files are not required, they are just files you need during the reproduction, but we don't need your reproduction files in the repository. Just you signing off on the reproduction log.