search

castorini / pyserini

Pyserini is a Python toolkit for reproducible information retrieval research with sparse and dense representations.
http://pyserini.io/
Apache License 2.0
1.57k stars 349 forks source link

Update requirements nmslib compatible with late pybind11 #1898

Closed GrigoriiTarasov closed 2 months ago

lintool commented 2 months ago

Our instructions specify use of conda to install nmslib: https://github.com/castorini/pyserini/blob/master/docs/installation.md

Have you tried that?

GrigoriiTarasov commented 2 months ago

Yes, I done both Linux instruction and from source: without pybind11 update they led to https://github.com/pybind/pybind11/discussions/4333 and now installing from scratch the pybind11 in which above is solved is in conflict with too new nmslib. WIth a suggested version nmslib all worked.

lintool commented 2 months ago

What Python version are you on?

GrigoriiTarasov commented 2 months ago

python 3.11.9 h955ad1f_0

lintool commented 2 months ago

python 3.11.9 h955ad1f_0

Hrm. Our entire group is still on Python 3.10... wondering if this makes a difference?

GrigoriiTarasov commented 2 months ago

Oh I see, I started from

pip install torch faiss-cpu
pip install pyserini

as it was under Linux section and thought

conda create -n pyserini python=3.10 -y
conda activate pyserini

related to Mac as it under Mac section, but this part has to be common for all the platforms.

lintool commented 2 months ago

Shouldn't hurt... but also untested wrt other parts of Pyserini.