search

castorini / ura-projects

0 stars 1 forks source link

Make Anserini and Pyserini work fully on Windows #16

Open lintool opened 11 months ago

lintool commented 11 months ago

With WSL?

Making sure tests, etc. fully pass.

techandy42 commented 11 months ago

I will look into this.

techandy42 commented 11 months ago

Hello @lintool, I completed the task for both Anserini and Pyserini and made the pull requests. With WSL2, all of Anserini and Pyserini builds and tests work. (Anserini: https://github.com/castorini/anserini/pull/2243, Pyserini: https://github.com/castorini/pyserini/pull/1705)

techandy42 commented 11 months ago

Hello @lintool, I reformatted my changes correctly and created new pull requests for both Anserini and Pyserini (Anserini: https://github.com/castorini/anserini/pull/2245, Pyserini: https://github.com/castorini/pyserini/pull/1706). The issues with the changes in the last line of the files in the previous pull-requests were because of my VS Code auto-formatting, but I got that fixed now.

lintool commented 11 months ago

hi @gitHubAndyLee2020 I guess with WSL, everything seems to work fine on Windows? This seems much better than cywgin... previous users have complained a lot about failing tests, etc.

Just to confirm, python -m unittest works fine with Pyserini on Windows with WSL and everything works? (i.e., all tests pass?)

techandy42 commented 11 months ago

Hello @lintool. Yes, everything works properly with WSL2 on Windows, including python -m unittest (all tests passed).