castwide / solargraph-utils

A Node module for interacting with the Solargraph rubygem.
Other
5 stars 10 forks source link

Run solargraph in interactive zsh shell #6

Closed existentialmutt closed 5 years ago

existentialmutt commented 6 years ago

Hey thanks again- I've been really loving having a ruby language server in atom!

Strangely, after things had been running great for a while, I started getting gem incompatibility issues when starting up the solargraph server. Tracked it down to RVM not loading in the shell that was used to run the command. Making it an interactive shell got RVM loading and fixed the issue.

castwide commented 6 years ago

Awesome, thanks for catching this.

Can you confirm whether it still works without the -l parameter? e.g., change line 25 of src/commands.ts to this:

var shellArgs = ['-c', shellEscape(cmd)];

I suspect that this is related to #5, and the correct solution might be to add the -l parameter for bash and the -i parameter for zsh.