Hello, I've been following along with a couple old issues some have reported, and that I have personally experienced with renaming.
The respective issues I think are related are #135 and #107.
I am not familiar with language server protocol, but was able to add a few tests that correlate with the renaming bug that I and others have had in our respective editors. The first 2 tests are related to comments at the bottom of #135, and the extra element in rename.result[:changes]['file:///file.rb'] I believe is the 'overlapping ranges error'. Both of those tests are currently failing.
The final test at the bottom is for #107, but seems to be passing, so it's just an added test at this point.
If time permits, I'll come back soon and figure out how to get these tests to pass, but wanted to post the PR in case it sparks an idea for anyone more familiar with LSP.
Hello, I've been following along with a couple old issues some have reported, and that I have personally experienced with renaming.
The respective issues I think are related are #135 and #107.
I am not familiar with language server protocol, but was able to add a few tests that correlate with the renaming bug that I and others have had in our respective editors. The first 2 tests are related to comments at the bottom of #135, and the extra element in
rename.result[:changes]['file:///file.rb']I believe is the 'overlapping ranges error'. Both of those tests are currently failing.The final test at the bottom is for #107, but seems to be passing, so it's just an added test at this point.
If time permits, I'll come back soon and figure out how to get these tests to pass, but wanted to post the PR in case it sparks an idea for anyone more familiar with LSP.