castwide / solargraph

A Ruby language server.
https://solargraph.org
MIT License
1.87k stars 154 forks source link

Fixed Solargraph::Cache.base_dir #702

Closed earl-gresh closed 4 months ago

earl-gresh commented 6 months ago

Switched Ruby's || operator to 'or' to account for precedence.

When the environment variable SOLARGRAPH_CACHE is defined, the cache is always configured to use XDG_CACHE_HOME. When XDG_CACHE_HOME is defined, it silently replaces SOLARGRAPH_CACHE. When it is undefined, it leads to a TypeError.

castwide commented 4 months ago

This bug was addressed in #704. If there's some issue I missed, please let me know.