Open lekemula opened 1 month ago
remove the exclude: ['spec/*/'] folder as a default config?
@castwide It turns out that keeping the specs
folder in the exclude
list, is a good idea. Luckily Solargraph still parses them when opened or changed in the editor, something which I initially thought was a bug, but in our case, it's a very important feature allowing us to "lazy parse" specs 🥳
https://github.com/lekemula/solargraph-rspec/commit/3f0fc39e59e99bf9430e55c52ecb88650e49315e
It's worth mentioning that with this setup, there was no performance issues or degradation whatsoever when testing against Gitlab's codebase.
Hi,
ICYMI: https://github.com/castwide/solargraph/issues/683#issuecomment-2106296460
The new plugin includes all existing functionality + much more! (See gem's README: https://github.com/lekemula/solargraph-rspec.)
After you have given it a try and find it worthy, being that
rspec
is the de-facto preferred testing framework in Ruby, would it make sense to:solargraph-rails
in the Readme/Documentation?exclude: ['spec/**/*']
folder as a default config? https://github.com/castwide/solargraph/blob/d610a6bb77f2f95f9e01b70e79e625958b66e523/lib/solargraph/workspace/config.rb#L151~~Looking forward to your feedback.
Resolves: https://github.com/castwide/solargraph/issues/683