search

castwide / vscode-solargraph

A Visual Studio Code extension for Solargraph.
Other
425 stars 23 forks source link

Solargraph gives no failure message when solargraph gem isn't installed #100

Closed connorshea closed 5 years ago

connorshea commented 5 years ago

I'm not sure why this is/was happening, maybe because I upgraded to Ruby 2.6, or because of something else, but I had "Starting the Solargraph language server..." stuck in my VSCode bottom bar and nothing was happening. I was unaware of the problem for a week or two and just assumed the extension had an issue of some sort that'd be fixed in a few days.

I'm not sure if there's no "gem not found" error or if the extension was getting stuck somewhere and failed to warn me for some other reason, but it'd be nice if there was some sort of notification for this problem :)

Extension version: 0.19.1 VS Code version: Code 1.30.2 (61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8, 2019-01-07T22:48:31.260Z) OS version: Darwin x64 18.2.0

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz (4 x 2300)| |GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|2, 2, 2| |Memory (System)|8.00GB (0.28GB free)| |Process Argv|-psn_0_1016056| |Screen Reader|no| |VM|0%|
castwide commented 5 years ago

There should definitely be an indication from the extension when the gem isn't installed. I'll look into it.

castwide commented 5 years ago

Extension v0.19.2 reinstates the notification when the gem is not found.

connorshea commented 5 years ago

Thanks!