CleanCut
commented
3 years ago @castwide Any tips for getting this across the finish line?
At this point, vsce package successfully produces a .vsix file and I can install it with code --install-extension solargraph-0.22.0.vsix BUT obviously I've done something wrong -- I don't get any error messages from VS Code when I load a Ruby file...but nothing works either. When I attempt to run a command via cmd-shift-p, the commands show up in the list, but when I select any of them I get an error like Command 'Solargraph: Restart Solargraph' resulted in an error (command 'solargraph.restart' not found).
I'm pretty sure it has to do with all the updating-of-stuff, but I'm not sure where to look next.
I've double-checked the package.json format, and as far as I can tell the formatting / values are all correct. 🤔
castwide
This pull request makes the
commandPathsetting reliably portable when it is a relative path by making it relative to the VS Code project root instead of relative to VS Code's current working directory (the current working directory varies depending on how and where VS Code was launched).This makes it so that if you vendor
solargraphinto, e.g.bin/solargraphin a repository, and vendor your.vscode/settings.jsonwith a"solargraph.commandPath": "bin/solargraph",into the repository as well, then that setting functions on another person's machine, no matter how they launch VS Code.Other Stuff
npm update, because npm was complaining about security vulnerabilities in the existing versionsvscodepackage and added the replacement packages@type/vscodeandvscode-test(as per this documentation). This not only took care of another security vulnerability, it also had the benefit of adding a newUri.joinPathmethod I wanted to use in this fix.vsce packagewouldn't work otherwise.