Solargraph seems to ignore terminal.integrated.automationShell

[noniq]

I have terminal.integrated.automationShell.osx set to /bin/bash, but the Solargraph extension still tries to start solargraph via zsh (which is the system’s default shell).

Note that there is a funny workaround: If I have a macOS terminal session where the current shell is bash and I start VS Code from this terminal via code, then the Solargraph extensions uses bash instead of zsh. (Because starting VS Code from the terminal means it inherits the environment from the terminal, including process.env["SHELL"].)

I think the Solargraph extension should use whatever shell is configured in terminal.integrated.automationShell (respective the newer terminal.integrated.automationProfile) for running subprocesses – as far as I understand these settings are meant for exactly this kind of situations.

[castwide]

Thanks for bringing this to my attention. I'll work on it for the next release.

[nassredean]

I'm having the same problem, but using the new syntax in VSCode for setting shell. I have "terminal.integrated.defaultProfile.osx": "fish" in my vscode settings with a corresponding shell definition:

"terminal.integrated.profiles.osx": {
  "fish": {
    "path": "/opt/homebrew/bin/fish",
    "args": [
      "-l"
    ]
  }
},

But starting solargraph still tries to run in zsh:

[Error - 7:22:16 PM] Starting client failed
zsh:1: command not found: solargraph

[goatandsheep]

terminal.integrated.automationShell.osx is now deprecated.

terminal.integrated.defaultProfile.osx is the new thing

[nassredean]

terminal.integrated.automationShell.osx is now deprecated.

terminal.integrated.defaultProfile.osx is the new thing

@goatandsheep not sure if you saw my reply but I have "terminal.integrated.defaultProfile.osx": "fish" set and that also does not work.