castwide / vscode-solargraph

A Visual Studio Code extension for Solargraph.
Other
425 stars 24 forks source link

Autocomplete/documentation does not work #28

Closed mwoskowicz closed 6 years ago

mwoskowicz commented 6 years ago

VSCode 1.20.1

When I type and press ctrl+space, the methods do show but there's no documentation.

image

I have gem installed. Should anything else be done to make this working?

castwide commented 6 years ago

What version of the gem are you using? This is what I get with 0.17.2:

image

castwide commented 6 years ago

I was able to reproduce this issue when I opened the file alone without opening a folder. I'll look into it.

image

castwide commented 6 years ago

The problem was in the server. It didn't cache an API map for undefined workspaces, so the extension couldn't resolve details for completion items.

A fix is pushed to the castwide/solargraph master branch. It should work correctly in gem version 0.17.3.

mwoskowicz commented 6 years ago

Thanks @castwide One more thing, a little offtopic. Is it still possible to set documentation to be written inline under function name instead of in the right panel? Couldn't find such option. Screen as example: image

castwide commented 6 years ago

@mwoskowicz The right panel is a feature of VS Code itself. They changed the appearance of completion items a few versions ago. That screen capture is based on VS Code from March 2017. I should update the gif in the README.

Unfortunately, I don't know of a way to change the layout. If there's a configuration setting for it, I haven't been able to find it.

castwide commented 6 years ago

Fix published in gem v0.17.3.