search

casualcore / casual

casual xatmi implementation
http://casual.laz.se
MIT License
7 stars 2 forks source link

service: untangle the lookup request handler from pending lookup 'processing' #228

Closed AlbsAgren closed 1 month ago

AlbsAgren commented 1 year ago

The service manager reuses the same set of functions for pending lookups when receiving lookup requests as is used to process pending lookups when the state changes for other reasons, such as services being advertised or processes dying. Under some circumstances this causes the SM to send lookup replies that the caller isn't expecting. Ideally these "flows" should be separated to make this less error prone and easier to reason about.

lazan commented 1 month ago

@AlbsAgren I think this got a lot better in the SM-refactoring commits? Could you verify, and if it's still to complecting, update this issue more precisely what you think still should be done.

AlbsAgren commented 1 month ago

@lazan Yeah, I had a look at it and it feels a lot easier to follow. Closing this.