search

casualshammy / NameplateAuras

Addon for World of Warcraft that displays buffs/debuffs of players above their nameplates.
https://wow.curseforge.com/projects/nameplateauras
8 stars 1 forks source link

Outdated method names #236

Open kasiopec opened 1 month ago

kasiopec commented 1 month ago

UPD: i can see in commits that it was fixed, but i don't see changes in the release

From what i can tell methods names got changed https://warcraft.wiki.gg/wiki/Patch_11.0.0/API_changes#:~:text=tint%0A%20%20%2D%20isLootObject-,Deprecated%20API,-These%20API%20functions 

Message: ...nterface/AddOns/NameplateAuras/locales/invariant.lua:2: attempt to call global 'GetSpellInfo' (a nil value)
Time: Wed Aug 14 23:30:01 2024
Count: 1
Stack: ...nterface/AddOns/NameplateAuras/locales/invariant.lua:2: attempt to call global 'GetSpellInfo' (a nil value)
Message: Interface/AddOns/NameplateAuras/src/utils.lua:15: attempt to call local 'GetSpellTexture' (a nil value)
Time: Wed Aug 14 23:30:01 2024
Count: 1
Stack: Interface/AddOns/NameplateAuras/src/utils.lua:15: attempt to call local 'GetSpellTexture' (a nil value)
Message: Interface/AddOns/NameplateAuras/src/spells.lua:34: attempt to index local 'SpellNameByID' (a nil value)
Time: Wed Aug 14 23:30:01 2024
Count: 1
Stack: Interface/AddOns/NameplateAuras/src/spells.lua:34: attempt to index local 'SpellNameByID' (a nil value)

Message: ...terface/AddOns/NameplateAuras/src/NameplateAuras.lua:317: attempt to call field 'deepcopy' (a nil value)
Time: Wed Aug 14 23:30:06 2024
Count: 1
Stack: ...terface/AddOns/NameplateAuras/src/NameplateAuras.lua:317: attempt to call field 'deepcopy' (a nil value)
[string "@Interface/AddOns/NameplateAuras/src/NameplateAuras.lua"]:317: in function <...terface/AddOns/NameplateAuras/src/NameplateAuras.lua:305>
[string "@Interface/AddOns/NameplateAuras/src/NameplateAuras.lua"]:373: in function `OnStartup'
[string "@Interface/AddOns/NameplateAuras/src/NameplateAuras.lua"]:1577: in function `?'
[string "@Interface/AddOns/NameplateAuras/src/NameplateAuras.lua"]:1520: in function <...terface/AddOns/NameplateAuras/src/NameplateAuras.lua:1520>

Locals: aceDBDefaults = <table> {
 profile = <table> {
 }
}
(*temporary) = <table> {
 BORDER_TYPE_CUSTOM = 2
 SPITEFUL_SPELL_ID = 69861
 BORDER_TYPE_BUILTIN = 1
 AURA_SORT_MODE_NONE = 1
 GLOW_TYPE_AUTOUSE = 3
 SHOW_ON_PLAYERS = 2
 AllAuraIconFrames = <table> {
 }
 ICON_GROW_DIRECTION_LEFT = 2
 EPIC_BG_ZONE_IDS = <table> {
 }
 Nameplates = <table> {
 }
 SHOW_ON_PLAYERS_AND_NPC = 1
 CONST_SPELL_MODE_DISABLED = 1
 EXPLOSIVE_ORB_NPC_ID_AS_STRING = "120651"
 ICON_ANIMATION_DISPLAY_MODE_NONE = 1
 BORDER_TEXTURES = <table> {
 }
 ICON_ALIGN_CENTER = 3
 SHOW_ON_NPC = 3
 MAX_AURA_ICON_SIZE = 75
 AURA_SORT_MODE_AURATYPE_EXPIRE = 6
 ICON_ANIMATION_DISPLAY_MODE_ALWAYS = 2
 ICON_ALIGN_BOTTOM_LEFT = 1
 INSTANCE_TYPE_SCENARIO = "scenario"
 AURA_TYPE_ANY = 3
 ICON_GROW_DIRECTION_DOWN = 4
 ICON_ALIGN_TOP_RIGHT = 2
 ICON_GROW_DIRECTION_RIGHT = 1
 GLOW_TYPE_ACTIONBUTTON = 2
 VERY_LONG_COOLDOWN_DURATION = 2592000
 AURA_TYPE_DEBUFF = 2
 INSTANCE_TYPE_ARENA = "arena"
 ICON_ANIMATION_TYPE_ALPHA = 2
 AURA_SORT_MODE_CUSTOM = 7
 ICON_ANIMATION_DISPLAY_MODE_THRESHOLD = 3
 INSTANCE_TYPE_PVP = "pvp"
 CONST_SPELL_MODE_MYAURAS = 3
 AURA_SORT_MODE_EXPIRETIME = 2
 EXPLOSIVE_ORB_SPELL_ID = 240446
 DR_TEXTURES = <table> {
 }
 EventFrame = Frame {
 }
 CONST_SPELL_MODE_ALL = 2
 AURA_TYPE_BUFF = 1
 INSTANCE_TYPE_RAID = "raid"
 GLOW_TYPE_NONE = 1
 GLOW_TYPE_PIXEL = 4
 GLOW_TYPE_ACTIONBUTTON_DIM = 5
 ICON_GROW_DIRECTION_UP = 3
 Interrupts = <table> {
 }
 INSTANCE_TYPE_PARTY = "party"
 INSTANCE_TYPE_UNKNOWN = "unknown"
 BORDER_TYPE_DISABLED = 3
 INSTANCE_TYPE_PVP_BG_40PPL = "pvp_bg_40ppl"
 GLOW_TIME_INFINITE = 2592000
 SPITEFUL_NPC_ID_STRING = "174773"
 AURA_SORT_MODE_ICONSIZE = 4
 INSTANCE_TYPE_NONE = "none"
}
(*temporary) = nil
(*temporary) = <table> {
 profile = <table> {
 }
}
(*temporary) = "attempt to call field 'deepcopy' (a nil value)"
addonTable = <table> {
 BORDER_TYPE_CUSTOM = 2
 SPITEFUL_SPELL_ID = 69861
 BORDER_TYPE_BUILTIN = 1
 AURA_SORT_MODE_NONE = 1
 GLOW_TYPE_AUTOUSE = 3
 SHOW_ON_PLAYERS = 2
 AllAuraIconFrames = <table> {
 }
 ICON_GROW_DIRECTION_LEFT = 2
 EPIC_BG_ZONE_IDS = <table> {
 }
 Nameplates = <table> {
 }
 SHOW_ON_PLAYERS_AND_NPC = 1
 CONST_SPELL_MODE_DISABLED = 1
 EXPLOSIVE_ORB_NPC_ID_AS_STRING = "120651"
 ICON_ANIMATION_DISPLAY_MODE_NONE = 1
 BORDER_TEXTURES = <table> {
 }
 ICON_ALIGN_CENTER = 3
 SHOW_ON_NPC = 3
 MAX_AURA_ICON_SIZE = 75
 AURA_SORT_MODE_AURATYPE_EXPIRE = 6
 ICON_ANIMATION_DISPLAY_MODE_ALWAYS = 2
 ICON_ALIGN_BOTTOM_LEFT = 1
 INSTANCE_TYPE_SCENARIO = "scenario"
 AURA_TYPE_ANY = 3
 ICON_GROW_DIRECTION_DOWN = 4
 ICON_ALIGN_TOP_RIGHT = 2
 ICON_GROW_DIRECTION_RIGHT = 1
 GLOW_TYPE_ACTIONBUTTON = 2
 VERY_LONG_COOLDOWN_DURATION = 2592000
 AURA_TYPE_DEBUFF = 2
 INSTANCE_TYPE_ARENA = "arena"
 ICON_ANIMATION_TYPE_ALPHA = 2
 AURA_SORT_MODE_CUSTOM = 7
 ICON_ANIMATION_DISPLAY_MODE_THRESHOLD = 3
 INSTANCE_TYPE_PVP = "pvp"
 CONST_SPELL_MODE_MYAURAS = 3
 AURA_SORT_MODE_EXPIRETIME = 2
 EXPLOSIVE_ORB_SPELL_ID = 240446
 DR_TEXTURES = <table> {
 }
 EventFrame = Frame {
 }
 CONST_SPELL_MODE_ALL = 2
 AURA_TYPE_BUFF = 1
 INSTANCE_TYPE_RAID = "raid"
 GLOW_TYPE_NONE = 1
 GLOW_TYPE_PIXEL = 4
 GLOW_TYPE_ACTIONBUTTON_DIM = 5
 ICON_GROW_DIRECTION_UP = 3
 Interrupts = <table> {
 }
 INSTANCE_TYPE_PARTY = "party"
 INSTANCE
Message: ...terface/AddOns/NameplateAuras/src/NameplateAuras.lua:1483: attempt to index upvalue 'db' (a nil value)
Time: Wed Aug 14 23:30:07 2024
Count: 1
Stack: ...terface/AddOns/NameplateAuras/src/NameplateAuras.lua:1483: attempt to index upvalue 'db' (a nil value)
[string "@Interface/AddOns/NameplateAuras/src/NameplateAuras.lua"]:1483: in function <...terface/AddOns/NameplateAuras/src/NameplateAuras.lua:1481>

Locals: currentTime = 52819.176000
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index upvalue 'db' (a nil value)"
db = nil
NameplatesVisible = <table> {
}
AurasPerNameplate = <table> {
}
casualshammy commented 1 month ago

What version are you using? 110002.2-release is the latest release.

kasiopec commented 1 month ago

What version are you using? 110002.2-release is the latest release.

yeah, should be it. One that was downloaded with wowup-cf tool.

but even if you will download latest release from github and check utils.lua it still uses old api.

casualshammy commented 1 month ago

What version are you using? 110002.2-release is the latest release.

yeah, should be it. One that was downloaded with wowup-cf tool.

but even if you will download latest release from github and check utils.lua it still uses old api.

110002.2-release from curseforge doesn't contain old spells api (at least GetSpellInfo and GetSpellTexture). I've just downloaded it and enabled test mode in game - no problems.

kasiopec commented 1 month ago

What version are you using? 110002.2-release is the latest release.

yeah, should be it. One that was downloaded with wowup-cf tool. but even if you will download latest release from github and check utils.lua it still uses old api.

110002.2-release from curseforge doesn't contain old spells api (at least GetSpellInfo and GetSpellTexture). I've just downloaded it and enabled test mode in game - no problems.

weird. Becuase here downloaded zip from release page and it has old outdated method names. on the same lines as it is throwing lua errors. Line 15, 16 etc

https://github.com/casualshammy/NameplateAuras/blob/d41f69e26f1b4f428a0954434763b23b9e2a21ac/src/utils.lua#L15

image image

but anyway, will try to play some time and see if it will throw again, maybe aliasing was failing

casualshammy commented 1 month ago

image