casualsnek / onthespot

qt based music downloader written in python
GNU General Public License v2.0
736 stars 53 forks source link

issues with save path when using ' on windows. Final conversion from ogg to mp3 fails due to output string error to ffmpeg. #114

Open Dave-Webster opened 5 months ago

Dave-Webster commented 5 months ago

%userpath%\80's GUI shows decode issue at 99%

The ' in the path to download too breaks the final conversion from ogg download to mp3. removing the ' from the path name allows it to work fine.

Windows 10 machine, on the spot current build.

Message: 'Sanitising string: "℗ 1985 Warner Records Inc."; Allow path separators: False' Arguments: () [2024-02-01 15:12:39,859 :: spotutils :: utils\spotify.py -> 97: sanitize_data() :: INFO] -> Sanitising string: "℗ 1985 Warner Records Inc."; Allow path separators: False [2024-02-01 15:12:42,893 :: spotutils :: utils\spotify.py -> 97: sanitize_data() :: INFO] -> Sanitising string: "C:\Users\Dave\Music\OnTheSpot\80's test\a-ha[1985] Hunting High and Low.~a-ha - Hunting High and Low - Take on Me.ogg"; Allow path separators: True [2024-02-01 15:12:42,894 :: spotutils :: utils\spotify.py -> 97: sanitize_data() :: INFO] -> Sanitising string: "C:\Users\Dave\Music\OnTheSpot\80's test\a-ha[1985] Hunting High and Low\a-ha - Hunting High and Low - Take on Me.mp3"; Allow path separators: True [2024-02-01 15:12:42,895 :: spotutils :: utils\spotify.py -> 178:convert_audio_format() :: INFO] -> Converting media with ffmpeg. Built commandline ['C:\Users\Dave\AppData\Local\Temp\_MEI39442\onthespot\bin\ffmpeg\ffmpeg.exe', '-i', 'C:\Users\Dave\Music\OnTheSpot\80s test\a-ha\[1985] Hunting High and Low\.~a-ha - Hunting High and Low - Take on Me.ogg', '-ar', '44100', '-ac', '2', '-b:a', '320k', 'C:\Users\Dave\Music\OnTheSpot\80s test\a-ha\[1985] Hunting High and Low\a-ha - Hunting High and Low - Take on Me.mp3'] ffmpeg version 6.0-essentials_build-www.gyan.dev Copyright (c) 2000-2023 the FFmpeg developers built with gcc 12.2.0 (Rev10, Built by MSYS2 project) configuration: --enable-gpl --enable-version3 --enable-static --disable-w32threads --disable-autodetect --enable-fontconfig --enable-iconv --enable-gnutls --enable-libxml2 --enable-gmp --enable-bzlib --enable-lzma --enable-zlib --enable-libsrt --enable-libssh --enable-libzmq --enable-avisynth --enable-sdl2 --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxvid --enable-libaom --enable-libopenjpeg --enable-libvpx --enable-mediafoundation --enable-libass --enable-libfreetype --enable-libfribidi --enable-libvidstab --enable-libvmaf --enable-libzimg --enable-amf --enable-cuda-llvm --enable-cuvid --enable-ffnvcodec --enable-nvdec --enable-nvenc --enable-d3d11va --enable-dxva2 --enable-libvpl --enable-libgme --enable-libopenmpt --enable-libopencore-amrwb --enable-libmp3lame --enable-libtheora --enable-libvo-amrwbenc --enable-libgsm --enable-libopencore-amrnb --enable-libopus --enable-libspeex --enable-libvorbis --enable-librubberband libavutil 58. 2.100 / 58. 2.100 libavcodec 60. 3.100 / 60. 3.100 libavformat 60. 3.100 / 60. 3.100 libavdevice 60. 1.100 / 60. 1.100 libavfilter 9. 3.100 / 9. 3.100 libswscale 7. 1.100 / 7. 1.100 libswresample 4. 10.100 / 4. 10.100 libpostproc 57. 1.100 / 57. 1.100 C:\Users\Dave\Music\OnTheSpot\80s test\a-ha[1985] Hunting High and Low.~a-ha - Hunting High and Low - Take on Me.ogg: No such file or directory [2024-02-01 15:12:42,909 :: worker.downloader.SESSION_DL_TH-91a75de7-58f8-4097-b426-06a455cbaaed :: worker\downloader.py -> 211: download_track() :: ERROR] -> Decoding error for track by id '2WfaOiMkCvy7F5fcp2zZ8L', possibly due to use of rate limited spotify account ! 1 | None