casualsnek / onthespot

qt based music downloader written in python
GNU General Public License v2.0
913 stars 78 forks source link

[BUG] More than half the tracks seem to fail downloading and im unsure why #153

Open yanon182 opened 1 month ago

yanon182 commented 1 month ago

Describe the bug Ive tried downloading a few albums, from orchestra, video game tracks, and some rock/metal albums and it works fine for a few songs then the songs start failing to download. If i close the application and come back after about 10-15 minutes and put the links back in they start downloading the ones that failed, but then it eventually starts failing again.

To Reproduce

I Just simply try to download a few albums and songs here and there will just fail, On a very old version of casualOnTheSpot it was giving an error of ''failed fetching audio key'' But im unsure if thats really the issue or not

Expected behavior I think we all know what we expected to happen, It wasnt this LOL

Screenshots https://gyazo.com/d0a685ff9cbb9d056cd7cdda23fdd82f

System Information (please complete the following information): Windows 10

justin025 commented 1 month ago

It's a rate limit, some users have had success increasing the download delay from 5 to 15.

Here is an issue with further context https://github.com/justin025/onthespot/issues/3

Alyakar commented 2 weeks ago

Hi, I'm not very sure, maybe the rate limit, but I think that this is also related to the tag's sanitizing.

I noticed that an album named like "album title ..." try to create a folder named "album title " and the final space is suppressed in the folder name when creating it, so when trying to sanitize the tags the album title doesn't correspond with the folder name (or something like that) and it fails. I could download an album with that problem, changing the album formatted name to just {rel_year} instead of {relyear}{album}.

I think some string must be trimmed somewhere... Hope it helps.

Greetings.

justin025 commented 1 week ago

@Alyakar Can you send logs of this so I can take a look, they should be in C:/Users/YOUR_USERNAME/.cache

Alyakar commented 1 week ago

Hi,

It was hard to find, but I think I found the fragment that exactly you need. I attach it.

Greetings.

El mié, 23 oct 2024 a las 0:15, Justin @.***>) escribió:

@Alyakar https://github.com/Alyakar Can you send logs of this so I can take a look, they should be in C:/Users/YOUR_USERNAME/.cache

— Reply to this email directly, view it on GitHub https://github.com/casualsnek/onthespot/issues/153#issuecomment-2430417798, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJIXATWR4R5VMBFRQTCOELTZ43FBPAVCNFSM6AAAAABOASI3EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZQGQYTONZZHA . You are receiving this because you were mentioned.Message ID: @.***>

justin025 commented 1 week ago

I am not sure if github email attaches documents because I do not see it on my side, you might need to login to upload the file here

Alyakar commented 1 week ago

Hello Again,

Sorry for the delay, a lot of unread e-mails...

I attach it here, hope it helps.

Regards. onthespot.log