search

casualsnek / onthespot

qt based music downloader written in python
GNU General Public License v2.0
745 stars 54 forks source link

M3u Playlist option doesn't work #26

Open PassiveLemon opened 1 year ago

PassiveLemon commented 1 year ago

I'm on Windows 10. I have M3u playlist option enabled and after all of the songs are either done downloading or already downloaded, it just repeats: "Playlist m3u8 checking ID #############" "Playlist ############# Has some items left to download" There is also no info on it in the readme so I'm not sure if there is something I am missing.

casualsnek commented 1 year ago

I just figured playlist creation fails if any item on playlist is at unavailable state in Spotify. I think this is the issue. Can you check downloads tab to see if any playlist items has 'Unavailable' status ?

PassiveLemon commented 1 year ago

I do have a playlist that had 4 unavailable items but this happened for my other playlists that don't have any unavailable items. It didn't matter whether any downloads failed, failed and then got re-downloaded, already had some downloaded, or successfully downloaded all of the songs in one go, it never made the m3u

casualsnek commented 1 year ago

I will check the issue and update the comment when i make changes.

PassiveLemon commented 1 year ago

image Just in case this helps

vortex91 commented 1 year ago

I fixed the code to handle "unavailable" and "failed" use casee. runtimedata.py: added "missing"
downlowder.py: added "missing.add(trk_track_id_str)" to " if not is_playable:" and "except Exception:" utility: changed logic of ddc to "set(downloaded_data.keys()).union(missing)" and " if track_id in missing:"

users can unzip and replace in proper folders the 3 files with the attachment and it will create m3u when unavaialble or failed to download

edits.zip

casualsnek commented 1 year ago

This should be fixed in development branch, can you try again if the playlist feature works as expected ?