search

casualsnek / onthespot

qt based music downloader written in python
GNU General Public License v2.0
741 stars 53 forks source link

Unable to create playlist when missing files. #38

Open skorakora opened 1 year ago

skorakora commented 1 year ago

HI. Some songs failed to download, adn program is unable to create m3u playlist as long as I have missing songs, Is there any way to avoid that/ skip those missing songs?

vortex91 commented 1 year ago

im having same issue. Is development on this stopped?

casualsnek commented 1 year ago

im having same issue. Is development on this stopped?

The development has not stopped, although i have my end of semester exams till 9th Apr. I'll start working on issues after that date ! Sorry for delayed development and bugfixes !

casualsnek commented 1 year ago

HI. Some songs failed to download, adn program is unable to create m3u playlist as long as I have missing songs, Is there any way to avoid that/ skip those missing songs?

Thanks for letting me know, i will add check for unavailable songs and handle them properly!

casualsnek commented 1 year ago

Can you share link to the playlist that has unavailable tracks ?

vortex91 commented 1 year ago

I fixed the code to handle "unavailable" and "failed" use casee. runtimedata.py: added "missing" downlowder.py: added "missing.add(trk_track_id_str)" to " if not is_playable:" and "except Exception:" utility: changed logic of ddc to "set(downloaded_data.keys()).union(missing)" and " if track_id in missing:"

users can unzip and replace in proper folders the 3 files with the attachment and it will create m3u when unavaialble or failed to download

edits.zip

example of playlist with "unavailable" and "failed" https://open.spotify.com/playlist/3c9viZYoVMFv4ygPoGFsaz

casualsnek commented 1 year ago

Hello, i have pushed changes regarding this issue in development branch (https://github.com/casualsnek/onthespot/commit/1bb6bec9ff054ba6773aedf8fb06b89ae7d2305e) ! Can you give it a try