casualsnek / onthespot

qt based music downloader written in python
GNU General Public License v2.0
741 stars 53 forks source link

Some songs fail at 99% #62

Closed ghost closed 1 year ago

ghost commented 1 year ago

I'm using the latest developmentBranch build and some songs fail at 99%

[2023-05-20 01:52:09,075 :: worker.downloader.SESSION_DL_TH-810c87d7-4119-4e36-9b93-93722a94d6f8 :: worker\downloader.py -> 222: download_track() :: ERROR] -> Download failed for track by id '44UnT7KIVgEQFkUeXUp3OJ', Unexpected error: Traceback (most recent call last): File "PIL\PngImagePlugin.py", line 1286, in _save KeyError: 'CMYK'

The above exception was the direct cause of the following exception:

Traceback (most recent call last): File "worker\downloader.py", line 172, in download_track File "utils\spotify.py", line 203, in set_music_thumbnail File "PIL\Image.py", line 2432, in save File "PIL\PngImagePlugin.py", line 1289, in _save OSError: cannot write mode CMYK as PNG ! [2023-05-20 01:52:09,082 :: worker.downloader.SESSION_DL_TH-810c87d7-4119-4e36-9b93-93722a94d6f8 :: worker\downloader.py -> 377: run() :: ERROR] -> Download process returned false: 44UnT7KIVgEQFkUeXUp3OJ

image

casualsnek commented 1 year ago

I'm using the latest developmentBranch build and some songs fail at 99%

[2023-05-20 01:52:09,075 :: worker.downloader.SESSION_DL_TH-810c87d7-4119-4e36-9b93-93722a94d6f8 :: worker\downloader.py -> 222: download_track() :: ERROR] -> Download failed for track by id '44UnT7KIVgEQFkUeXUp3OJ', Unexpected error: Traceback (most recent call last): File "PIL\PngImagePlugin.py", line 1286, in _save KeyError: 'CMYK'

The above exception was the direct cause of the following exception:

Traceback (most recent call last): File "worker\downloader.py", line 172, in download_track File "utils\spotify.py", line 203, in set_music_thumbnail File "PIL\Image.py", line 2432, in save File "PIL\PngImagePlugin.py", line 1289, in _save OSError: cannot write mode CMYK as PNG ! [2023-05-20 01:52:09,082 :: worker.downloader.SESSION_DL_TH-810c87d7-4119-4e36-9b93-93722a94d6f8 :: worker\downloader.py -> 377: run() :: ERROR] -> Download process returned false: 44UnT7KIVgEQFkUeXUp3OJ

image

Just pushed https://github.com/casualsnek/onthespot/commit/3d10727edf91edf4d235857ba6ca1e48993d2969 can you pull the latest development branch and see if it's working now ?

ghost commented 1 year ago

It worked. thank you.