search

casualsnek / onthespot

qt based music downloader written in python
GNU General Public License v2.0
736 stars 53 forks source link

[Feature]Keep Only Main Artist #93

Open cj360 opened 10 months ago

cj360 commented 10 months ago

I would like an option to keep just the main or first listed artist instead of "artist; accompanying artist".

mwwdh commented 10 months ago

I hope i understand correctly but think i want the same.

When i click "download discography" i would like to only download just this. Just the list when you click on "discography" from the artist in Spotify.

casualsnek commented 10 months ago

This is different than what cj360 wants in my opinion, cj360 wants only one artist in the track metadata.

The issue you described is fixed on the main branch which is not contained in last release. There is a lot of rewrite going on in rewrite branch, so releases has been paused for a while ! If you need i can build a binary from main branch which should fix download discography issue !

mwwdh commented 10 months ago

I build from source. Sorry for hijacking this issue, it was my mistake. I meant i do not want to download the "appears on" album when i click "Download Discography".

casualsnek commented 10 months ago

I would like an option to keep just the main or first listed artist instead of "artist; accompanying artist".

This sounds reasonable, i will probably add a flag for this in rewrite. Current onthespot codebase is only getting bugfixes while a rewrite is being worked on, so this feature may take a while to be available !

casualsnek commented 10 months ago

I build from source. Sorry for hijacking this issue, it was my mistake. I meant i do not want to download the "appears on" album when i click "Download Discography".

Can you build again ? Your issue should be fixed by https://github.com/casualsnek/onthespot/pull/94 now !

mwwdh commented 10 months ago

I build again and it works as expected, thank you!

cj360 commented 9 months ago

Let me know if this should be on its own issue/ticket as this feels related:

Is there a setting to save albums under the artist? I changed my settings and now its only saving albums together. Where the default settings were saving files as Artist(s)/Album/Song(s).