casualsnek / waydroid_script

Python Script to add OpenGapps, Magisk, libhoudini translation library and libndk translation library to waydroid !
GNU General Public License v3.0
1.89k stars 170 forks source link

the install instruction have one small think missing #112

Closed Idcrafter closed 1 year ago

Idcrafter commented 1 year ago

There is the requirements.txt missing after the -r which isn't working when not included

grafik

nimaaskarian commented 1 year ago

I recommend using venv:

git clone https://github.com/casualsnek/waydroid_script
cd waydriod_script
python3 -m venv .
./bin/pip install -r requirements.txt
sudo ./bin/python3 main.py
Idcrafter commented 1 year ago

i also would suggest changing it in the README because it could create confusion for not so experienced people and yes i always do venv because otherwise could i brick my os

nimaaskarian commented 1 year ago

i also would suggest changing it in the README because it could create confusion for not so experienced people and yes i always do venv because otherwise could i brick my os

Yeah of course. I'm not the projects maintainer unfortunately, I just suggested so the project maintainers would write venv in README.md instead.

casualsnek commented 1 year ago

Thanks for feedback, i'll test and update README asap !

FOSSProponent9436 commented 1 year ago

Seems to have been fixed: https://github.com/casualsnek/waydroid_script/pull/110