search

casualsnek / waydroid_script

Python Script to add OpenGapps, Magisk, libhoudini translation library and libndk translation library to waydroid !
GNU General Public License v3.0
1.65k stars 157 forks source link

Fixed a bug preventing libhoudini install #14

Closed DGdev91 closed 2 years ago

DGdev91 commented 2 years ago

Libhoudini installation is still broken after last commit: FileNotFoundError: [Errno 2] No such file or directory: '/tmp/waydroidimage/system/etc/init/hw/init.rc'

Setting the default value for os.environ.get("ANDROID_VERSION") back to 10 (it's the same for install_ndk method, wich is working fine)

casualsnek commented 2 years ago

This makes libhoudini installable on Android 10, but breaks on Android 11 images ( also Houdini is mainly intended for a11), you could have used 

export ANDROID_VERSION=10
sudo python3 waydroid_script -h

to force install on Android 10 images !

DGdev91 commented 2 years ago

Then, the ndk installation script is broken too (it uses "10" as default). Anyway, Waydroid's image on github is currently an Android 10 image, would't make more sense to assume "10" by default?

I mean, Magisk and Gapps scripts are mainly for Android 10 too.

....Maybe we should use something else to figure out if the image is Android 10 or 11. Maybe just checking if "{imagemount}/system/etc/init/hw/init.rc" exists shall do the trick?

casualsnek commented 2 years ago

Then, the ndk installation script is broken too (it uses "10" as default). Anyway, Waydroid's image on github is currently an Android 10 image, would't make more sense to assume "10" by default?

I mean, Magisk and Gapps scripts are mainly for Android 10 too.

....Maybe we should use something else to figure out if the image is Android 10 or 11. Maybe just checking if "{imagemount}/system/etc/init/hw/init.rc" exists shall do the trick?

Yes, maybe i should check if '/init.rc' exists or not, if it exists modify that else modify 'system/etc/init/hw/init.rc' and just get rid of "ANDROID_VERSION" environment variable !

DGdev91 commented 2 years ago

Then, the ndk installation script is broken too (it uses "10" as default). Anyway, Waydroid's image on github is currently an Android 10 image, would't make more sense to assume "10" by default? I mean, Magisk and Gapps scripts are mainly for Android 10 too. ....Maybe we should use something else to figure out if the image is Android 10 or 11. Maybe just checking if "{imagemount}/system/etc/init/hw/init.rc" exists shall do the trick?

Yes, maybe i should check if '/init.rc' exists or not, if it exists modify that else modify 'system/etc/init/hw/init.rc' and just get rid of "ANDROID_VERSION" environment variable !

Ok, done that. Created new pul request https://github.com/casualsnek/waydroid_script/pull/16

Closing this one.