casualsnek / waydroid_script

Python Script to add OpenGapps, Magisk, libhoudini translation library and libndk translation library to waydroid !
GNU General Public License v3.0
1.65k stars 157 forks source link

Readme corrections #2

Closed Kabouik closed 2 years ago

Kabouik commented 2 years ago

Thanks for this nice script! I only used it for Magisk because I use microG and not OpenGapps (though I would need to carefully check their differences, pros and cons), but found two slight issues in the readme:

python3 -m pip -r requirements.txt

should read

python3 -m pip install -r requirements.txt

Also, since the script will later need to be run as root, I believe the requirements.txt should be installed with sudo too. Installing them with the above command (without sudo) was not enough to install Magisk because tqdm (installed as user) could not be found when executing the waydroid_extras.py as root.

casualsnek commented 2 years ago

Thank you, I just updated README.md with changes !