search

casualsnek / waydroid_script

Python Script to add OpenGapps, Magisk, libhoudini translation library and libndk translation library to waydroid !
GNU General Public License v3.0
1.65k stars 157 forks source link

Magisk Script Successful but Magisk not Installed #3

Closed levone1 closed 2 years ago

levone1 commented 2 years ago

Using Waydroid on Sailfish OS, according to https://github.com/lal883/tama-sailfish-waydroid-instructios, and I ran Magisk script, and rebooted, and Magisk app installed, but doesn't do anything without installing Magisk, (installation status shows "n/a"). The only method option given to install is to select and patch a file. I don't think patching Sailfish boot img would work, but not sure what other file I would patch ...

I saw note in README about it being a "bootless" installation, and that modules won't work, but as it is for me, root won't even work, and the app does nothing...

casualsnek commented 2 years ago

What is the version of your installed magisk manager ?

levone1 commented 2 years ago

v. 23.0 (23000). It started as a different version, but then I got update notification, so figured I'd rry it to see if it changed anything.

Also, when the app first opens, there's a message, "Abnormal State... not supposes to be system app..."

levone1 commented 2 years ago

So, I went through init-magisk.sh script to try manually, and I was able to make folders and symlinks by changing permissions etc., but then I get error "/sbin/magisk not executable 32-bit elf" so seems like script installed wrong version on my phone .. Any way to specify arch?

casualsnek commented 2 years ago

So, I went through init-magisk.sh script to try manually, and I was able to make folders and symlinks by changing permissions etc., but then I get error "/sbin/magisk not executable 32-bit elf" so seems like script installed wrong version on my phone .. Any way to specify arch?

https://github.com/casualsnek/waydroid_script/blob/c784d42cf93f75418550a43f4b95f9c9d25cec8e/waydroid_extras.py#L365 Replace arch_dir, with 'arm' if on arm based system else 'x86' then replace set arch="" (blank) if on 32bit system if on 64bit system set arch="64", This way you can force specific binary to be copied !

For the abnormal state message, i will update script to install this app as user and will also be updating default magisk version !

levone1 commented 2 years ago

Thanks Script ran successfully with edits, and the result is the same, except that now there is no Magisk binary... /sbin folder contains only magiskinit and magiskboot files

casualsnek commented 2 years ago

Thanks Script ran successfully with edits, and the result is the same, except that now there is no Magisk binary... /sbin folder contains only magiskinit and magiskboot files

what does platform.machine() on python shell return on your device ?

For no magisk binary issue, as i have seen on system magisk manager says magisk is not installed ( this may be due to missing binary ), for now you can run this script every time before stating waydroid if you plan to use su within android, while i try to figure out how to fix it !

Kabouik commented 2 years ago

I have observed the same issue as @levone1, albeit on Droidian (I didn't try on my SFOS devices yet because none of them is up to date, and kernel modules are not there in my version). The script's -m option works well and does add a Magisk icon in Waydroid, but then when I open it I can't make Magisk work. If I install it as a system app, then on later launches it will complain that there was an error with it and I should set it as a user application again. I also observed what @levone1 said about patching being the only option available. I'm sorry I don't remember the details as I don't have my Droidian phone with me at the moment.

dariox86 commented 2 years ago

Same issue on PinePhone.

ShapeShifter499 commented 2 years ago

@casualsnek I've been playing around with magisk before. You need to put in a check for aarch64. If we are on a aarch64 device, like the pinephone, copy over 'magiskinit64' to the system as 'magiskinit' otherwise it's not going to work.

casualsnek commented 2 years ago

@casualsnek I've been playing around with magisk before. You need to put in a check for aarch64. If we are on a aarch64 device, like the pinephone, copy over 'magiskinit64' to the system as 'magiskinit' otherwise it's not going to work.

can you send what does python -c "import platform;print(platform.machine())" return on your device ?

ShapeShifter499 commented 2 years ago

can you send what does python -c "import platform;print(platform.machine())" return on your device ?

PinePhone running Arch Linux ARM from: https://github.com/dreemurrs-embedded/Pine64-Arch Below is what I have.

uname -a outputs Linux danctnix 5.14.13-1-danctnix #1 SMP PREMPT Mon Oct 18 14:34:41 UTC 2021 aarch64 GNU/Linux

python -c "import platform;print(platform.machine())" outputs aarch64

rizzini commented 2 years ago

Same issue here. I'm on Arch x86_64.

casualsnek commented 2 years ago

Thanks Script ran successfully with edits, and the result is the same, except that now there is no Magisk binary... /sbin folder contains only magiskinit and magiskboot files

Can you please try again to see if magisk works ? I just pushed a small change that should make it fix this issue !

casualsnek commented 2 years ago

can you send what does python -c "import platform;print(platform.machine())" return on your device ?

PinePhone running Arch Linux ARM from: https://github.com/dreemurrs-embedded/Pine64-Arch Below is what I have.

uname -a outputs Linux danctnix 5.14.13-1-danctnix #1 SMP PREMPT Mon Oct 18 14:34:41 UTC 2021 aarch64 GNU/Linux

python -c "import platform;print(platform.machine())" outputs aarch64

can you check if the correct magiskinit is copied after the latest commit ?

levone1 commented 2 years ago

Thanks Script ran successfully with edits, and the result is the same, except that now there is no Magisk binary... /sbin folder contains only magiskinit and magiskboot files

Can you please try again to see if magisk works ? I just pushed a small change that should make it fix this issue !

working now, thanks. Magisk app initially opens with message "additional setup required..." and if I press "ok" it reboots, and then still shows the same message after reboot. But if I just ignore it, it works fine, and grants root.