search

cat-cfs / gcbm_preprocessing

0 stars 2 forks source link

add CBMAgeIndicators module to GCBM config template #37

Closed B-Ron12 closed 7 years ago

B-Ron12 commented 7 years ago

allows for age_class to be a reporting classifier (good to have in disturbance_indicators but can multiply the number of records and size of a db)

   "CBMAgeIndicators": {
        "enabled": true,
        "library": "moja.modules.cbm",
        "order": 15
    },
B-Ron12 commented 7 years ago

the "order" parameter may vary by what is wanted out of the ageIndicator... In my case I want the stand age at disturbance. This means the order has to come before the disturbance module. If others want to have the age after its grown and decayed then the order will be last

naddison1 commented 7 years ago

So it should be one before CBMDisturbanceEventModule? "Modules": { "CBMBuildLandUnitModule": { "library": "moja.modules.cbm", "order": 1 }, "CBMSequencer": { "library": "moja.modules.cbm", "order": 2 }, "CBMAgeIndicators": { "enabled": true, "library": "moja.modules.cbm", "order": 3 }, "CBMDisturbanceEventModule": { "library": "moja.modules.cbm", "order": 4, "settings": { "vars": "$disturbance_vars" }, "enabled": true }, ...

mfellows commented 7 years ago

This issue is a bit outdated with the latest build, sorry Nick - the behaviour of the age class module is less order-dependent now (a good thing): now it only needs to go before CBMAggregatorLandUnitData, and the order shouldn't be user-configurable anymore.

naddison1 commented 7 years ago

https://github.com/cat-miti/gcbm_preprocessing/commit/855646bb7f496617bb81df3dfe8d24f6a7c3d189