search

cat-cfs / gcbm_preprocessing

0 stars 2 forks source link

GCBM configs should be parameterized for Master Batch #40

Closed naddison1 closed 7 years ago

naddison1 commented 7 years ago

It seems that master batch will likely always succeed the preprocessor so that configs can be parameterized with that assumption, allowing more flexibility in master batch configurations

B-Ron12 commented 7 years ago

I think the hope was to not always have to run preprocessor, right? so once the preprocessor run is satisfactory, master batch could be run multiple times from that

naddison1 commented 7 years ago

Yeah. This will make that better because more of the settings will be set in the master batch opposed to the preprocessor. However the drawback of this is that it makes it hard to run GCBM after the preprocessor without master batch

naddison1 commented 7 years ago

https://github.com/cat-miti/gcbm_preprocessing/commit/b44b0dce494ba980f84add15f2ea315691add086