search

cat-in-136 / redmine_hearts

a redmine plugin which provides intra-Redmine Like/Fav reactions
https://www.redmine.org/plugins/redmine_hearts
GNU General Public License v2.0
33 stars 3 forks source link

heart link is an absolute path (contains the domain name) and not relative #41

Closed danielecr closed 1 year ago

danielecr commented 1 year ago

The link for like a comment is absolute, containing schema, domains and url, like so:

<a class="icon icon-heart" data-remote="true" rel="nofollow" data-method="delete" href="http://example.domain/hearts/heart?object_id=10646&amp;object_type=journal"><span class="heart-link-label">Like</span></a>

and not like this:

<a class="icon icon-heart" data-remote="true" rel="nofollow" data-method="delete" href="/hearts/heart?object_id=10646&amp;object_type=journal"><span class="heart-link-label">Like</span></a>

the last form is better when service is provided through a proxy and redmine is not aware of ssl layer