cataclysmbnteam / Cataclysm-BN

Cataclysm: Bright Nights, A fork/variant of Cataclysm:DDA by CleverRaven.
https://docs.cataclysmbn.org
Other
695 stars 273 forks source link

Camera displays in vehicles can show security camera views as night time even though it is daylight in some circumstances. #1196

Open Relgar opened 2 years ago

Relgar commented 2 years ago

Describe the bug

Not quite sure under what circumstances it occurs, but when viewing through a security camera system sometimes, the camera display will show the security camera view as though it were night time even though it is daylight outside.

Steps To Reproduce

  1. Download the uploaded save.
  2. Turn on camera display system located at the seat in the vehicle (player starts here), cameras are located at the 4 corners of the vehicle, giving a 360 degree view.
  3. Observe the night view.
  4. Open hatch doors on either side.
  5. It is morning

Expected behavior

  1. Morning light view through the camera system

Screenshots

image

image

Versions and configuration

Additional context

Save File Camera Display.zip

Coolthulhu commented 2 years ago

What do you mean by "night view"?

Cameras have a range offset, which means that they see things as if they were further away. I think it's 20 tiles for most cameras. With the hatches open, it looks like distant tiles are dark. This is because perceived light of a tile decreases with distance. The most likely explanation I see here is that the camera range offset is making them see things as if they were still in that "dark range". As the day becomes brighter, the "day range" would expand and it should look like normal.

Relgar commented 2 years ago

By night view I mean it looks as though it is still night time when view through the camera. Let me run through this save a little more and see if the camera view changes as the time solders on - either way, it does sound like the offset thing, but it was just very disconcerting that looking through a camera would show 'dim light' when it's actually bright outside.

Relgar commented 2 years ago

Yup, vision in the cameras returns to normal as the day progresses. Should this 20 tile offset be removed? What was the original intent with the inclusion?

Coolthulhu commented 2 years ago

What was the original intent with the inclusion?

Cameras having worse range than eyes.

Relgar commented 2 years ago

Is it possible to cut off max range while preserving the ratio of dim-to-bright tiles? I.e. if max eyesight range has a radius of say 20 bright with 2 dark tiles, could cameras be set to 10 bright / 1 dim? Whatever they currently have implemented feels off by a good amount, hence this weird edge case scenario.