cataclysmbnteam / Cataclysm-BN

Cataclysm: Bright Nights, A fork/variant of Cataclysm:DDA by CleverRaven.
https://docs.cataclysmbn.org
Other
660 stars 262 forks source link

.30-06 Springfield M2 AP, black powder problems #1213

Closed ProjectileWaterfowl closed 2 years ago

ProjectileWaterfowl commented 2 years ago

There's a bunch of issues with .30-06 Springfield M2 AP, black powder. First, it should probably be named .30-06 M2 AP, black powder because neither the reloaded nor the base ammunition add on the extra "Springfield." Second, it has only 2 armor penetration, which is worse than the 5 penetration that the regular .30-06 Springfield, black powder has. For reference, the normal M2 AP has 18 armor penetration, and 5,56 black powder has 3. Lastly, it has the same description as all the .30-06 Springfield ammo variants instead of the .30-06 M2 AP like the reloaded version does.

chaosvolt commented 2 years ago

Rifle-caliber rounds in general have some weirdly low arpen values, and all blackpowder variants halve that already-low AP. The "blackpowder AP" issue sounds like either it's copying from the wrong item or whoever wrote the JSON for it set the value explicitly in an incorrect manner.

An overhaul of rifle-caliber arpen is part of what I want to tackle in https://github.com/cataclysmbnteam/Cataclysm-BN/issues/359 but I keep putting it off because hashing out exactly how to handle things consistently is hard.

ProjectileWaterfowl commented 2 years ago

Normal rounds:

.30-06 Springfield .30-06 Springfield, reloaded .30-06 Springfield, black powder

AP rounds:

.30-06 M2 AP .30-06 M2 AP, reloaded .30-06 Springfield M2 AP, black powder

The last one is the odd one out. The Springfield is fine, like Winchester. So if it's on the black powder AP, it should be on all of the AP.

Noticed the wonky values, nice to know it's being worked on.