Curdling milk bug

[Firestorm01X2]

User bug restored from user screenshot.

Describe the bug

When I try to put curdling mill into the fermenting vat I get errors and the curdles disappear

I've also tried putting various musts (wine/mead etc) into the vat and they worked fine. Its just the curdles that break the vat

Steps To Reproduce

I craft regular curdle milk from cows milk. The I put sime in containers (usually into a plastic jerrycan) amd tjem I put the container info fermentation vat. Then when I examine on the vat I get error screen "fvat_ful was empty" and curdle mix vanushes

Expected behavior

I expected some fermented curdles from from the vat for cheese making. But vat doesn't give me any. I only get error messages instead (see the log from them)

Screenshots

https://i.ibb.co/mzhHpVs/spam-again.jpg

Versions and configuration

Additional context

[cbmcat2]

Here is some extra info:

Versions and configuration

• OS: Windows
  • OS Version: 10.0 2009
• Game Version: d99ad58 [64-bit]
• Graphics Version: Tiles
• Game Language: []
• Mods loaded: [ Bright Nights [dda], Disable NPC Needs [no_npc_food], Simplified Nutrition [novitamins], Aftershock [aftershock], C.R.I.T Expansion Mod [crt_expansion], No Hope [no_hope], Craftable Gun Pack [craftgp], Medieval Mod Reborn [Medieval_Mod_Reborn], MST Extra [MST_Extra], Mining Mod [Mining_Mod], Tankmod: Revived [Tankmod_Revived], Cataclysm++ [Cata++], Dorf Life [Dorf_Life], Faster Stamina Regen [stamina_regen_buff] ]

Additional context

Debug log: https://ufile.io/fc5hf75l Save file: https://ufile.io/3e7mcjov

[chaosvolt]

Is it possibly because, if I recall, curdling milk is the only fermentable item with spoils_in set?

[cbmcat2]

if I recall, curdling milk is the only fermentable item with spoils_in set?

Sounds like that could be something. I always craft with unrotten foods but maybe the vat no longer knows how to account for such variables.

[chaosvolt]

That's why I added curdling milk to Nonperishable Overhaul's overrides waaay back in the old days yeah, as a "just in case because this seems like something that could eventually break" thing.

That said, I feel like cheesemaking could stand to be tweaked a bit as an alternative, in favor of quickly making short-lived farmer's cheese that you can then smoke or otherwise dry out: https://www.youtube.com/watch?v=vlQZ3NPnoLk

Getting usable curds out of milk and then preserving it using methods already in use for other autolearned recipes would also be easier to justify having it be autolearned, unlike the current rennet-based method that's booklearn-only last I checked.

[Coolthulhu]

Looks like vat needs "DONT_REMOVE_ROTTEN" flag. If it has it, then it is not working.

[chaosvolt]

Empty and full vats have it, yeah:

1. https://github.com/cataclysmbnteam/Cataclysm-BN/blob/upload/data/json/furniture_and_terrain/furniture-tools.json#L781
2. https://github.com/cataclysmbnteam/Cataclysm-BN/blob/upload/data/json/furniture_and_terrain/furniture-tools.json#L816

[chaosvolt]

Another oddity I've noticed: "brewable": { "time": "4 hours", "results": [ "milk_curdled" ] }

Might warrant a separate issue report if all items are affected by this?

[Coolthulhu]

@chaosvolt

time_duration item::brewing_time() const
{
    return is_brewable() ? type->brewable->time * calendar::season_ratio() : 0_turns;
}

It scales with season length for some reason. I'd just get rid of the scaling.

[chaosvolt]

Weird. Seems like more fodder for a PR then. So that just leaves sorting out what might be causing issues with curdling milk.

Part of my planned changes to cheesemaking, as mentioned in https://github.com/cataclysmbnteam/Cataclysm-BN/issues/883, would involve altering the fermentation time for 4 hours down to 1 hour, as part of some changes to make it so that making a large batch of cheese the "hard way" will reliably take less time than making the same amount of cheese the other way.

I've got some JSON set aside for tinkering with to tackle that idea after I've got my fork properly re-synced.

[cbmcat2]

Love that you guys are looking into the cheese problem. I'm gonna become the mightiest cheese maker once things have been sorted! My npc's will be eating nothing but grilled cheese sandwiches for years after this one.

[RoyalFox2140]

We don't seem to have curdled milk as an item anymore, currently cheese is a recipe and not a fermentation. The linked PR's both seem to have solved the bug. @chaosvolt