Infinite eyebot resource exploit

RoyalFox2140 commented 1 year ago

Describe the bug

Smashing alarm furniture (Vending machines, Reinforced vending machines) will trigger an alarm that spawns an eyebot. This is fine unless you fail to smash it. Being unable to smash a reinforced vending machine I can spawn an infinite number of eyebots, and using a 13 strength character I can use a normal vending machine with fist attacks for infinite eyebots.

Steps To Reproduce

Find vending machine (or reinforced)
Attempt to smash it with something that won't break it.
Wait a few minutes.
Attempt to smash it again.
Now you have as many eyebots as you want.

Screenshots

Versions and configuration

OS: Windows
- OS Version: Windows 10 Pro for Workstations 64 bit (10.0 Build 19045
Game Version: 0.2 [64-bit]
Graphics Version: Tiles
Game Language: English [en_US]
Mods loaded: [ Bright Nights [bn], Elevated bridges [elevated_bridges], Craftable Gun Pack [craftgp], Alternative Map Key [alt_map_key], FoxMod for Bright Nights [FoxMod], Fuji's Military Profession Pack [fuji_mpp], Aftershock [aftershock], Arcana and Magic Items [Arcana], Bright Nights (wrapper) [dda], Cataclysm++ [Cata++], Lones Soda mod [coke_flavors], Craftable Bullet Casings [CasingCrafting], MST Extra [MST_Extra], Dorf Life [Dorf_Life], Fewer Farms [Fewer_Farms], SzQmod [SzQmod], Tankmod: Revived [Tankmod_Revived], No Addictions [No_Addictions], Nonperishable Overhaul [Nonperishable_Overhaul] ]

Additional context

No response

scarf005 commented 1 year ago

ok, so after looking at the code it goes like this:

vending machine has "ALARMED" flag.
when you kick at vending machine, either map::shoot or map::bash_furn triggers TIMED_EVENT_WANTED event. it also stores position.
TIMED_EVENT_WANTED spawns an eyebot nearby.

i think it's kinda tricky to solve this issue at the moment because there's no easy way to mark how many eyebots are spawned.

RoyalFox2140 commented 1 year ago

This PR from DDA may be relevant to the issue if it wasn't already merged into BN. It appears eyebots used to spawn unlimited riot control bots, and the solution may be relevant to this.

https://github.com/CleverRaven/Cataclysm-DDA/pull/53584

Ignaramico commented 1 year ago

what about a quick hotfix of making the vending machine really easy to break?

RoyalFox2140 commented 1 year ago

That would allow players quick access to tons of medicine in the reinforced vending machines, plus anything else they are set to guard. It would shift the issue from infinite eyebots to easily gaining valuables that used to be hard to access.

chaosvolt commented 1 year ago

When I get home I'll try to look into porting over the linked PR, hopefully.

chaosvolt commented 1 year ago

So, looking at this, the PR kinda fails to actually solve the specific problem being reported here. Infinite eyebots are still perfectly exploitable, that PR only limits how many riot bots they can spawn.

RoyalFox2140 commented 1 year ago

Perhaps its still an issue in DDA. I haven't played it in years to know.

DoubleBullfrog commented 5 days ago

Resurrecting this ancient issue to add that you can farm an absolute ton of superalloy from the riot and police bots spawned by doing this. It makes superalloy a very easy resource to get.

ZChris13 commented 5 days ago

as far as I can tell this is the ONLY viable source of superalloy, actually I find the idea of summoning a horde of robots from their bunker in order to loot their valuable metals thematically interesting but they're kind of chumps right now

chaosvolt commented 4 days ago

Steel mills and some lab locations are the main "intended" places to get superalloy, in addition to incidental spawns of robots in appropriate locations.

cataclysmbnteam / Cataclysm-BN