Autodoc instantly kills NPCs during CBM installation

[cinornu]

Describe the bug

Just a heads up that I used a translator first. I don't speak English very well :(

After several rounds of testing, we finalized the conditions under which the bug occurs. But other than that, the conditions under which bug occurs (mods, env...) are still unknown.

This bug causes Autodoc to install CBMs on NPCs, and when they leave the reality bubble, it throws an error and insta kills the NPC. I've implemented that exact condition in the attached save file, so you can check it out for yourself.

Steps To Reproduce

1. Install CBM with a probability of failure to the NPC using vh_autodoc. However, it appears that vehicle must be similar to #3315 to trigger the bug.
2. move to a location outside reality bubble, but with a different z-axis at the same time
3. wait for the total installation time of the CBM
4. return to the vehicle
5. move out of reality bubble
6. error occurs and NPC dies instantly.

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.3448 (22H2)
• Game Version: 8b4336b [64-bit]
• Graphics Version: Tiles
• LAPI Version: 1
• Game Language: []
• Mods loaded: [ 밝은 밤 [bn], NPC 욕구 제거 [no_npc_food], 영양수치 단순화 [novitamins], 철도역 금지 [No_Rail_Stations], 고가 다리 [elevated_bridges], Arcana and Magic Items [Arcana], 불페큘라의 추가 지형 및 몬스터 [Lowfieldmonster], C.R.I.T. 확장팩 [crt_expansion], 프로젝트: 다람쥐 [Jake's_Squirrel_mod], DIY weaponry [DIY_weaponry], 매직클리즘 [magiclysm], anti-fungal gear [anti_fungal_gears], AZF의 모드 [AZF], Croppable Rice [Rice_Mod_kor], Expanded Archery [ExArch], Makeshift Items Mod [makeshift__], Pneumatic fun [pneumo_fun], 날이 너무 더워요 [p_cooler], 총기 제조 팩 [craftgp], Arcana/C.R.I.T. Patchmod [Arcana_Crit_Patch], Arcana/Magiclysm Patchmod [Arcana_Magiclysm_Patch], Mining Mod [Mining_Mod], 뉴 잉글랜드 지팡이술 [NE_Staff_arts], Patch뉴 잉글랜드 지팡이술_Arcana [NE_Staff_arts_arcana], Patch뉴 잉글랜드 지팡이술_magiclysm [NE_Staff_arts_magiclysm], 임시 타일 추가 모드 [desu_cdda_tile_add], 허브01 지하실 되살리기 모드 [Revive_hub01_basement], Blazemod - Vehicle Additions Pack [blazemod__], Overhaul Tileset [Overhaul Tileset], 도그밋의 인벤토리 [dogmeat_mod], 총기 리밸런싱 +@ [SF_Weapons], 폭발 좀비 제거 [No_Explosive_Zombies], Autodoc Harmless and Perfect [autodoc_harmless_perfect], better cataclysm [better_cataclysm], Faster Stamina Regen [stamina_regen_buff], Magiclysm No Class Limit [magiclysm_no_class_limit], 가혹한 세상 [Dontstarve], 해수면 더 많이 낮추기 [piss_river], 기술 성장 비례 능력 성장 [StatsThroughSkills], 더 좋은 민첩스탯 [dexbuff], 더러운 옷 금지 [no_filthy_clothing], 들어올리기 제한 해제 [disable_lifting], 민첩할수록 빠르게 [speedydex], 살해 수 반영 능력 성장 [stats_through_kills], 온도 디버프 감소 [reducedtempeffect], 좀비 부활 방지 [no_reviving_zombies], 진균 성장 제한 [limit_fungal_growth], 표적 돌연변이 [TaMu_BnKo], 도시 개발 [Urban_Development], 지도 기호 수정 [alt_map_key], 기괴하고도 강력한 장비들 [BPG], 모드 타일 오버홀 [MOT] ]

Additional context

ERROR DEBUGMSG : D:\a\Cataclysm-BN\Cataclysm-BN\src\map.cpp:1170 [unboard_vehicle] map::unboard_vehicle: vehicle not found

See the attached save file for details. I've made it so that after loading, moving straight up will cause an error.

mods : https://www.dropbox.com/scl/fi/ik9nifluyaoc1i4hmcpzd/report_mods.zip?rlkey=j6wk2zbdg7vmv0q6x8cgq12lp&dl=0 save : https://www.dropbox.com/scl/fi/sczdos312jz2ihmewee4p/npc_instadeath.zip?rlkey=bmru4yzb0lickmuuca184b5i8&dl=0

[scarf005]

did the bug happen without additional mods?

혹시 모드 없이도 동일한 버그가 발생한 경우가 있나요?

[cinornu]

did the bug happen without additional mods?

혹시 모드 없이도 동일한 버그가 발생한 경우가 있나요?

모드가 없는 상태에선 동일한 조건을 확보할 수가 없어서 테스트해도 같은 결과가 나오지 않았습니다. 아마 커다랗고 물건이 꽉꽉 차있는 차량에서 발생하는 것 같아요. 오히려 다른 버그를 발견해서 이것도 제보할 예정입니다. 또한 방금 세이브 파일 최신화했습니다. 버그가 발생한 직후로 자동 세이브가 되는 바람에 다시 조건을 맞춰놨어요

[olanti-p]

I think I've tracked down what's going on here.

It all comes down to how the vehicle is positioned within a different submap from the NPC that's being operated on.

Red circle is the vehicle pivot point (should match its position on map), orange is the NPC that dies.

When you move north, the vehicle leaves the reality bubble first and gets unloaded. However, the NPC remains within the reality bubble because they're on a different submap, so operation_do_turn sees that NPC is inside the bubble and tries to check for the autodoc. There is no autodoc (the vehicle's gone), so it incurs "autodoc failure" which ends up bringing NPC's torso health to 0 and kills them.

https://github.com/cataclysmbnteam/Cataclysm-BN/blob/e82ebec7734021ad2ba56208a0bae5030ee15bfc/src/activity_handlers.cpp#L3565-L3584

The following "failed to unboard vehicle" error is of similar nature: NPC used to be seated within the loaded vehicle when it died, but the vehicle's gone, so it can't "unseat" from it on death.