cataclysmbnteam / Cataclysm-BN

Cataclysm: Bright Nights, A fork/variant of Cataclysm:DDA by CleverRaven.
https://docs.cataclysmbn.org
Other
662 stars 260 forks source link

Sealed containers stay sealed when emptied #3588

Open YeOldeMiller opened 10 months ago

YeOldeMiller commented 10 months ago

Describe the bug

Sealed containers do not consistently lose their sealed status on being emptied or consumed from.

Steps To Reproduce

  1. Spawn some preserved food in glass jars or tin cans of any size.
  2. Eat some of the food / empty a container / use up some of the contents through crafting.

Expected behavior:

Observed behavior:

Screenshots

image

Versions and configuration

Additional context

No response

Treah commented 10 months ago

I have also noticed this on a modded item the birch jug. It cannot be filled from a environmental water source but can be the target of crafted liquids and drank from. I suspect its being seen as constantly sealed.

YeOldeMiller commented 10 months ago

Doesn't look fixed to me: image This is 47ee09b

UPD: tins and jars now do seem to get unsealed when emptied or eaten from, but in the latter case, it should happen on first change, not when fully emptied. When used up through crafting, still doesn't work at all.

YeOldeMiller commented 10 months ago

Still getting the same behavior in 0f8ea67 when items from containers are used for crafting.

image

YeOldeMiller commented 9 months ago

Another detail, most likely related to the main issue: when partially eating from a container located in an adjacent tile (not in inventory), a log message appears: You leave the empty %container_name%, even if said container is not empty:

image