cataclysmbnteam / Cataclysm-BN

Cataclysm: Bright Nights, A fork/variant of Cataclysm:DDA by CleverRaven.
https://docs.cataclysmbn.org
Other
692 stars 272 forks source link

Martial weapon styles and "transforming" items do not functon correctly when "used" while wielded #4371

Open pejorativefox opened 7 months ago

pejorativefox commented 7 months ago

Describe the bug

When wielding an item like expandable baton (collapsed) and activating it to expand, the proper wield/unwield hooks do not seem to be called.

Steps To Reproduce

Screenshots

No response

Versions and configuration

Additional context

Investigating this it's clear that the message for wielding a weapon with an active martial style is in the normal player on_wield. Since this message is absent I'm assuming it's a deeper kludge with transforming items as I don't see how the wield actions could possibly be running if the message doesn't appear.

Ignaramico commented 7 months ago

but does the MA still aplies even without the UI message?

pejorativefox commented 7 months ago

Not only does it apply, it is properly reflected in the Style: area of the information panel. As mentioned given the placement of where the message is triggered there is no un_wield/wield happening and I assume that's the behavior that one would expect when adding a transforming item like this?

Ignaramico commented 7 months ago

i bet someone moved something and the function that shows the message isnt called, since the weapon check is being done and applied