Android save.json character reset bug

[RainaLute]

Describe the bug

After opening the save it resets my character completely

Steps To Reproduce

1- Start the world 2- Spawn a bit far away from where you last save and quitted completely naked and lose off proffession

Screenshots

Versions and configuration

• OS: Android
  • OS Version: Manufacturer: Xiaomi; Model: M2004J19C; Release: 12; Incremental: V13.0.3.0.SJCTRXM;
• Game Version: 522a610 [64-bit]
• Graphics Version: Tiles
• LAPI Version: 2
• Game Language: English [en_US]
• Mods loaded: [ Bright Nights [bn], Disable NPC Needs [no_npc_food], Simplified Nutrition [novitamins], No Rail Stations [No_Rail_Stations], Prevent Zombie Revivication [no_reviving_zombies], Limit Fungal Growth [limit_fungal_growth], C.R.I.T. Expansion [crt_expansion], Advanced Gear [adv_gear], Armor Up! Survivor Expansion [ArmUpSurvEx], Craftable Gun Pack [craftgp], Expanded Archery [ExArch], More Survivor Stuff [more_survivor_stuff], Alternative Basement Layouts [basement_extension], sees-player icon, HitButton_iso [sees_player_hitbutton], sees-player icon, retrodays [sees_player_retro], Bionic Slots [cbm_slots], Fuji's Military Profession Pack [fuji_mpp], Manual Bionic Installation [manualbionicinstall], SpeedyDex [speedydex], Stats Through Kills [stats_through_kills], Stronger archery [bow_opness], BioCo Content [bioco], Bionic Space Expander [Bionic_Space_Expander], Bionics Systems Recipes [bio_recipes], Pneumatic fun [pneumo_fun], Large capacity storage CBMs [eps_cbm], Magical Nights [MagicalNights], Blazemod - Vehicle Additions Pack [blazemod] ]

Additional context

[Uploading Cridersville.zip…]()

[olanti-p]

I'm not sure what's precisely going on here, but it seems that the game uses wrong parser function for reading the saved integer back from JSON. It saves a 64-bit integer, but tries to load it back as a 32-bit integer, so it doesn't fit and throws a parse error.

Uploading Cridersville.zip…

It seems you have submitted the issue form before waiting for the upload to finish (the text changes to file name once that happens).

[olanti-p]

On further thought, in code that number means count of references, which in theory should stay far, far, far below limits of 32-bit unsigned int. https://github.com/cataclysmbnteam/Cataclysm-BN/blob/5ab65d545fc76b3cbb8832bb4fbff922464a2949/src/safe_reference.cpp#L23-L26

But in the screenshot, it seems that the count has reached -1 for some reason, which caused overflow and had it appear as 2^32-1 = 4294967295, which got saved, and then promptly failed to be loaded. So the root of the issue is more likely somewhere inside reference tracking code.

[olanti-p]

For archival purposes, here's the save file from the issue: Cridersville.zip

And the problematic snippet:

  "safe_references": { "items": [ 11602, 4294967295 ] },

Another save file from same user: Boulder.zip

Different values this time - this doesn't even look like integer overflow, maybe memory corruption?

  "safe_references": { "items": [ 18446744073709551615, 2636248448, 11322597028362325620, 2636247792, 98784247841, 50559 ] },

As a note, those numbers don't repeat anywhere else in the save folder.