Butchery yield needs to be capped

RoyalFox2140 commented 6 months ago

Describe the bug

Butchery yields is based on butchering quality which is good, but it has no cap to yield. With high enough quality you can gain more products than the creature weighs.

Steps To Reproduce

Use a test item with a ridiculous butchering quality
Find something to butcher
Do it.

Screenshots

Versions and configuration

OS: Windows
- OS Version: 10.0.19045.3448 (22H2)
Game Version: 35a8baa [64-bit]
Graphics Version: Tiles
LAPI Version: 2
Game Language: English [en_US]
Mods loaded: [ Bright Nights [bn], Craftable Gun Pack [craftgp], Alternative Map Key [alt_map_key], Fuji's Military Profession Pack [fuji_mpp], Craftable Bullet Casings [CasingCrafting], MST Extra [MST_Extra], Tankmod: Revived [Tankmod_Revived], Essence 2200 BN [Essence2200_BN], Essence 2200 Tweaks [FoxTweaks], No Addictions [No_Addictions], Limit Fungal Growth [limit_fungal_growth], Disable NPC Needs [no_npc_food], Simplified Nutrition [novitamins], OMT Resources [omt_resources], Flowing Water [flowing_water], No Filthy Clothing [no_filthy_clothing], Cataclysm++ [Cata++], No Wasps [No_Wasps] ]

Additional context

No response

VissValdyr commented 6 months ago

Butcher quality is only affecting negative numbers. Butcher quality only affects speed. @Coolthulhu said so years ago. So this is a curious thing indeed.

VissValdyr commented 6 months ago

But maybe for the low values we thing are adequate (till 50), so breaking it for the sake of breaking it... Not sure if it should be considered to be a bug then

RoyalFox2140 commented 6 months ago

A cap is essentially required because any bionics like the surgical scalpels, or any fictitious new item or furniture we add to increase butchery speed via high butchering quality is going to cause issues with preservation of mass, we could never add an Auto-Butcher furniture that gives 100% yield and in half the time of a human because there is no cap at 100%. (That is ignoring other limitations with power tools not using charges when used as a tool.)

A cap should also be one of the easiest changes to make so futureproofing the code here is worthwhile. We can't reasonably expect to always use 50 butchering quality for the remainder of the project.

cataclysmbnteam / Cataclysm-BN