You must input `denatured_alcohol` at first!

[NappingOcean]

Describe the bug

I can't reload alcohol-fueled soldering iron with methanol until denatured alcohol has been reloaded and removed. I suspect that character_functions.cpp is in trouble.

Steps To Reproduce

1. Make a player.
2. Spawn alcohol-fueled soldering iron and methanol.
3. Try to reload the iron with methanol.
4. Then spawn denatured alcohol and reload with it.
5. Remove denatured alcohol and repeat 3.

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.4529 (22H2)
• Game Version: f1e2f47 [64-bit]
• Graphics Version: Tiles
• LAPI Version: 2
• Game Language: English [en_US]
• Mods loaded: [ Bright Nights [bn], Disable NPC Needs [no_npc_food], Simplified Nutrition [novitamins], No Rail Stations [No_Rail_Stations], Prevent Zombie Revivication [no_reviving_zombies], Limit Fungal Growth [limit_fungal_growth], Prevent Zombification [no_zombify], Stats Through Kills [stats_through_kills], Stats Through Skills [StatsThroughSkills], Magical Nights [MagicalNights], Wield Wild Weapons [WIELD_WILD_WEAPONS] ]

Additional context

No response

[SilearFlare]

@RoyalFox2140 Needs verification

I can verify that you can't reload an alcohol fueled soldering iron with methanol.

Steps to reproduce:

Craft or spawn the damn thing

Then try to reload it with methanol. Doesn't work.

Here, pictograms for reference.

Crafted the thing, tried to reload with methanol, does not work. Debugged myself some denatured alcohol, now it accepts both options.

tldr: something with how the reload code is handled had a fucky wucky and it will only accept methanol if it is fed even an ounce of denatured alcohol first, despite both of them meeting the concentrated alcohol flag requirement. Shoutout to the only other dude playing innawoods because this literally happens the second you try to use a soldering iron that isn't battery powered, and methanol is extracted from wood instead of concentrated alcohol, so it's the only option in the wild short of making some boozeberry mixed alcohol and then concentrating that into denatured alcohol just to get the damn thing to work (alas, extremely impractical) Edit: can also reproduce this by spawning the item, and not only crafting it (the item does not spawn with charges of denatured alcohol).

pls fix cooldude thx

[RoyalFox2140]

pls fix cooldude thx

So This needs to be pointed out. Summoning me to an issue report isn't going to get me to fix them. You may find it surprising but not all collaborators on the project can code well (or at all)

[RoyalFox2140]

As for people who actually CAN work on magazine code you're looking at asking BroadFlatNails on the Discord AKA Coolthulhu on the Github, Jove if this was related to item identity and a bug caused by it, or other devs if they're interested/willing/qualified. You can ask in Development and see who might know what's going on. A number of dev roles are also busy with their lives or other code work on the project.

[RoyalFox2140]

Looks like the ammo type is copy-from'd. I wonder if this is related.