cataclysmbnteam / Cataclysm-BN

Cataclysm: Bright Nights, A fork/variant of Cataclysm:DDA by CleverRaven.
https://docs.cataclysmbn.org
Other
628 stars 255 forks source link

Merchants only trade entire stacks of currency, or, some stacks aren't spawned correctly in NPC inventory #4928

Open ChucklesTheBeard opened 4 days ago

ChucklesTheBeard commented 4 days ago

Describe the bug

NPCs will hand over entire stacks after asking for less than 1 stack's worth of items.

Steps To Reproduce

  1. Generate world with item spawn scaling >= 2
  2. Spawn as evacuee
  3. Reveal refugee center location from computer
  4. Debug teleport to refugee center
  5. Trade with merchant, offer at least $2.51 of stuff, and ask for one of the Merch (1) (###) items
  6. Receive entire stack of ### items instead of just the one.

Screenshots

2024-07-03 11_07_33-Cataclysm_ Bright Nights - bc559d9

2024-07-03 11_07_44-Cataclysm_ Bright Nights - bc559d9

Versions and configuration

Additional context

When trading for the correctly stacked Merch (122) item, 2024-07-03 11_12_09-Cataclysm_ Bright Nights - bc559d9

it does correctly only transfer the correct quantity. 2024-07-03 11_12_22-Cataclysm_ Bright Nights - bc559d9

Also reproduced on 2024-06-27 release

ChucklesTheBeard commented 3 days ago

Probably related:

4372

4006