Use VSync OFF - bug UI menus

NEONZARIN commented 1 month ago

Describe the bug

Disabling VSync option in settings causes UI bugs (disappearing menu). The first video shows a bug with vsync OFF. The second video with vsincON shows no bug.

Steps To Reproduce

Download the latest version of cbn-windows-tiles-x64-msvc. In the graphics settings, turn off Use VSync, re-enter the game. Create a new world with a new character. Spawn bottles of clean water. Set the character's thirst through the debug menu. Start drinking water.

Screenshots

https://github.com/user-attachments/assets/b7d8cc10-bde1-4e5c-832a-6530a832c531

https://github.com/user-attachments/assets/5611f52d-68ac-4b7b-bef0-68fbc3b46b28

Versions and configuration

OS: Windows
- OS Version: 10.0.19045.4123 (22H2)
Game Version: 8461a13 [64-bit]
Graphics Version: Tiles
LAPI Version: 2
Game Language: English [en_US]
Mods loaded: [ Bright Nights [bn], Disable NPC Needs [no_npc_food], Simplified Nutrition [novitamins], No Rail Stations [No_Rail_Stations], Prevent Zombie Revivication [no_reviving_zombies], Limit Fungal Growth [limit_fungal_growth], Item Category Overhaul [Item_Category_Overhaul] ]

Additional context

No response

scarf005 commented 1 month ago

This is a known issue (related: #4423) and was the reason vsync was made opt-out in #4433. It seems to only affect windows, however. maybe we could add warning for windows users on vsync.

RoyalFox2140 commented 1 month ago

Thank you for reproducing this and sorry that you are having this issue. I will forward it to @KheirFerrum due to its proximity with the massive port we did.

KheirFerrum commented 1 month ago

I need someone to confirm this. I can't replicate the issue. @scarf005 you have tried this with windows and can confirm that it happens?

scarf005 commented 1 month ago

I need someone to confirm this. I can't replicate the issue. @scarf005 you have tried this with windows and can confirm that it happens?

sorry, i do not own windows and thus this is hard for me to reproduce.

KheirFerrum commented 1 month ago

I need someone to confirm this. I can't replicate the issue. @scarf005 you have tried this with windows and can confirm that it happens?

sorry, i do not own windows and thus this is hard for me to reproduce.

Then it should be noted it may not be linked to the issue you linked to. If someone else can verify and reproduce that would be very helpful.

cataclysmbnteam / Cataclysm-BN