cataclysmbnteam / Cataclysm-BN

Cataclysm: Bright Nights, A fork/variant of Cataclysm:DDA by CleverRaven.
https://docs.cataclysmbn.org
Other
692 stars 273 forks source link

Character wields multiple pipes or planks instead of one. #5265

Open Proxiehunter opened 2 months ago

Proxiehunter commented 2 months ago

Describe the bug

When told to wield a pipe or plank the character should wield one not an entire fist full.

Steps To Reproduce

1: Stand within wielding distance of multiple pipes or planks (may need to be in the same stack or even standing on the stack or carrying them in inventory. Have not tested with them scattered around the character.)

2: Attempt to wield a pipe or plank as a weapon

3: See that character is wielding multiple pipes or planks

Screenshots

No response

Versions and configuration

Additional context

Enclosed save with character wielding five pipes. I have tested using pipes, planks, and pipe spears. Both pipes and planks were wielded in multiples while the pipe spear was not. I do not know if this applies to any other non-weapon items or if some weapons are also wielded in multiples under the same conditions.

It may be that this was intentionally implemented while I wasn't paying attention in order to let characters carry multiple items in their hands that didn't fit in the volume of the characters inventory but it seems like dragging the items using the drag hot key would work fine for that and it wouldn't cause confusion in players seeing themselves swinging two or more planks at zombies. If intentional perhaps the player could be asked how many to wield.

I suspect it's a bug though because if it was intentional I don't see why it wouldn't apply to everything including the pipe spears I attempted and failed to wield multiples of.

TEST.zip

scarf005 commented 2 months ago

this is likely a bug of making pipes or planks stackable.

chaosvolt commented 2 months ago

It is exactly that. So the real problem here is, essentially:

  1. It is both realistic (well I guess unless you go to an absolutely fucking bonkers extreme) and convenient for the player to carry more than one of a long thin item that could easily be bundled up in your arms.
  2. If you intend to actually bonk someone with them however, you only want to be wielding one.

If not for that innate catch-22 of competing priorities, the logical answer here would be restrict the player to only being able to wield a single item out of a stack if the item type is generic (thus still allowing unlimited wielding of ammo or comestibles, if we don't want to axe the feature wholesale).

RoyalFox2140 commented 2 months ago

Maybe if you try to swing the object while wielding many it opens a warning saying if you try you'll drop all but one. Then drop all but 1 without spending movecost to do so.

chaosvolt commented 2 months ago

Could work maybe.